From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by sourceware.org (Postfix) with ESMTPS id E3DB53856958 for ; Fri, 5 May 2023 17:59:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3DB53856958 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ispras.ru Received: from [10.10.3.121] (unknown [10.10.3.121]) by mail.ispras.ru (Postfix) with ESMTPS id 4EF9940737AF; Fri, 5 May 2023 17:59:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 4EF9940737AF Date: Fri, 5 May 2023 20:59:14 +0300 (MSK) From: Alexander Monakov To: Tamar Christina cc: Richard Biener , "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH] Makefile.in: clean up match.pd-related dependencies In-Reply-To: Message-ID: <423c180c-2753-d1fc-de90-86b9edf926af@ispras.ru> References: <20230505170241.19836-1-amonakov@ispras.ru> <7748AE6F-44E3-4AD9-9E65-6579134C412C@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-1141206397-1683309554=:22841" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1141206397-1683309554=:22841 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 5 May 2023, Tamar Christina wrote: > > > Am 05.05.2023 um 19:03 schrieb Alexander Monakov via Gcc-patches > patches@gcc.gnu.org>: > > > > > > Clean up confusing changes from the recent refactoring for parallel > > > match.pd build. > > > > > > gimple-match-head.o is not built. Remove related flags adjustment. > > > > > > Autogenerated gimple-match-N.o files do not depend on > > > gimple-match-exports.cc. > > > > > > {gimple,generic)-match-auto.h only depend on the prerequisites of the > > > corresponding s-{gimple,generic}-match stamp file, not any .cc file. > > > > LGTM > > > > > gcc/ChangeLog: > > > > > > * Makefile.in: (gimple-match-head.o-warn): Remove. > > > (GIMPLE_MATCH_PD_SEQ_SRC): Do not depend on > > > gimple-match-exports.cc. > > > (gimple-match-auto.h): Only depend on s-gimple-match. > > > (generic-match-auto.h): Likewise. > > > --- > > > > > > Tamar, do I understand correctly that you do not have more plans for > > > match.pd and I won't collide with you if I attempt more cleanups in this > > area? Thanks! > > No, but I'm also not sure why this change. > The idea here was that if gimple-head-export.cc changes you must have changed > genmatch.cc and so you need to regenerate the gimple-match-* which could change the header. gimple-head-export.cc does not exist. gimple-match-exports.cc is not a generated file. It's under source control and edited independently from genmatch.cc. It is compiled separately, producing gimple-match-exports.o. gimple-match-head.cc is also not a generated file, also under source control. It is transitively included into gimple-match-N.o files. If it changes, they will be rebuilt. This is not changed by my patch. gimple-match-auto.h is a generated file. It depends on s-gimple-match stamp file, which in turn depends on genmatch and match.pd. If either changes, the rule for the stamp file triggers. gimple-match-N.o files also depend on the stamp file, so they will be rebuilt as well. Is there some problem I'm not seeing? Thanks. Alexander > So not sure I agree with this. > > Thanks, > Tamar > > > > > > > gcc/Makefile.in | 9 +++------ > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > > > diff --git a/gcc/Makefile.in b/gcc/Makefile.in index > > > 7e7ac078c5..0cc13c37d0 100644 > > > --- a/gcc/Makefile.in > > > +++ b/gcc/Makefile.in > > > @@ -230,7 +230,6 @@ gengtype-lex.o-warn = -Wno-error > > > libgcov-util.o-warn = -Wno-error libgcov-driver-tool.o-warn = > > > -Wno-error libgcov-merge-tool.o-warn = -Wno-error > > > -gimple-match-head.o-warn = -Wno-unused gimple-match-exports.o-warn > > = > > > -Wno-unused dfp.o-warn = -Wno-strict-aliasing > > > > > > @@ -2674,12 +2673,10 @@ s-tm-texi: build/genhooks$(build_exeext) > > $(srcdir)/doc/tm.texi.in > > > false; \ > > > fi > > > > > > -$(GIMPLE_MATCH_PD_SEQ_SRC): s-gimple-match gimple-match-head.cc \ > > > - gimple-match-exports.cc; @true > > > -gimple-match-auto.h: s-gimple-match gimple-match-head.cc \ > > > - gimple-match-exports.cc; @true > > > +$(GIMPLE_MATCH_PD_SEQ_SRC): s-gimple-match gimple-match-head.cc; > > > +@true > > > +gimple-match-auto.h: s-gimple-match; @true > > > $(GENERIC_MATCH_PD_SEQ_SRC): s-generic-match generic-match-head.cc; > > > @true > > > -generic-match-auto.h: s-generic-match generic-match-head.cc; @true > > > +generic-match-auto.h: s-generic-match; @true > > > > > > s-gimple-match: build/genmatch$(build_exeext) \ > > > $(srcdir)/match.pd cfn-operators.pd > > > -- > > > 2.39.2 > > > > --8323328-1141206397-1683309554=:22841--