public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [pushed] c++: don't warn about internal interference sizes
Date: Wed, 15 Sep 2021 09:36:56 -0600	[thread overview]
Message-ID: <423c550a-1493-bf3e-7301-5544dbaae772@gmail.com> (raw)
In-Reply-To: <20210915153154.1111443-1-jason@redhat.com>



On 9/15/2021 9:31 AM, Jason Merrill via Gcc-patches wrote:
> Most any compilation on ARM/AArch64 was warning because the default L1 cache
> line size of 32B was smaller than the default
> std::hardware_constructive_interference_size of 64B.  This is mostly due to
> inaccurate --param l1-cache-line-size, but it's not helpful to complain to a
> user that didn't set the values.
>
> gcc/cp/ChangeLog:
>
> 	* decl.c (cxx_init_decl_processing): Only warn about odd
> 	interference sizes if they were specified with --param.
I wonder if that'll fix the arm-linux build failures that started 
showing up recently:

armeb-linux-gnueabi:

<built-in>: error: '--param constructive-interference-size=64' is 
greater than '--param l1-cache-line-size=32' [-Werror=interference-size]

I expect the other arm- linux configurations would show it as well, but 
they're only run once a week in my tester and I don't think they've been 
run since the recent changes in this space.

jeff


  reply	other threads:[~2021-09-15 15:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  2:36 [PATCH] c++: implement C++17 hardware interference size Jason Merrill
2021-07-16  2:41 ` Jason Merrill
2021-07-16  2:48   ` Noah Goldstein
2021-07-16 11:17     ` Jonathan Wakely
2021-07-16 13:27       ` Richard Earnshaw
2021-07-16 13:26   ` Jonathan Wakely
2021-07-16 15:12   ` Matthias Kretz
2021-07-16 15:30     ` Jason Merrill
2021-07-16 16:54       ` Jonathan Wakely
2021-07-16 18:43         ` Jason Merrill
2021-07-16 19:26         ` Matthias Kretz
2021-07-16 19:58           ` Jonathan Wakely
2021-07-17  8:14             ` Matthias Kretz
2021-07-17 13:32               ` Jonathan Wakely
2021-07-17 13:54                 ` Matthias Kretz
2021-07-17 21:37                   ` Jason Merrill
2021-07-19  9:41                     ` Richard Earnshaw
2021-07-20 16:43                       ` Jason Merrill
2021-09-10 13:16                         ` [PATCH RFC] " Jason Merrill
2021-09-14  7:56                           ` Christophe LYON
2021-09-15 10:25                             ` Richard Earnshaw
2021-09-15 11:30                               ` Christophe Lyon
2021-09-15 12:31                             ` Martin Liška
2021-09-15 15:31                               ` [pushed] c++: don't warn about internal interference sizes Jason Merrill
2021-09-15 15:36                                 ` Jeff Law [this message]
2021-09-15 15:38                                   ` Jason Merrill
2021-09-15 16:15                                     ` Christophe Lyon
2021-09-15 15:35                               ` [PATCH RFC] c++: implement C++17 hardware interference size Jason Merrill
2021-07-20 18:05                 ` [PATCH] " Thomas Rodgers
2021-07-16 17:20     ` Noah Goldstein
2021-07-16 19:37       ` Matthias Kretz
2021-07-16 21:23         ` Noah Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423c550a-1493-bf3e-7301-5544dbaae772@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).