From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57867 invoked by alias); 15 Jan 2020 11:34:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 57855 invoked by uid 89); 15 Jan 2020 11:34:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=personal X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2020 11:33:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82A4431B; Wed, 15 Jan 2020 03:33:49 -0800 (PST) Received: from e120077-lin.cambridge.arm.com (e120077-lin.cambridge.arm.com [10.2.78.81]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12D8B3F6C4; Wed, 15 Jan 2020 03:33:48 -0800 (PST) Subject: Re: [patch] contrib: Don't add push rules for personal and vendor spaces. From: "Richard Earnshaw (lists)" To: GCC Patches Cc: Jonathan Wakely References: <76a55bf3-9184-0e06-4776-25a6d514e3c3@arm.com> Message-ID: <425db110-7d0a-4bbc-94dc-960983b62d4c@arm.com> Date: Wed, 15 Jan 2020 12:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <76a55bf3-9184-0e06-4776-25a6d514e3c3@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00874.txt.bz2 On 14/01/2020 14:55, Richard Earnshaw (lists) wrote: > Originally, it seemed like a good idea to add automatic 'push' rules > to the git configuration, so that personal- and vendor-space commits > would automatically push to the right place. Unfortunately, this > changes git's behaviour and with these settings "git push" will try to > push all branches in a local tree up to the corresponding location on > the server (ignoring the push.default setting). The only known > mitigation for this is to ALWAYS use "git push ". > > So instead, we no-longer add those rules by default and will document > the options on the wiki. We don't automatically remove the push > entries but do print out the command that will do so, if the user so > wishes. > > OK? > > * gcc-git-customization.sh: Explain why we want the user's > upstream account name. Don't add push rules. Check if push rules > have been added and suggest that they should be removed. > * git-fetch-vendor.sh: Don't add push rules. > I've now checked this in. R.