From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 9E7AD385842A for ; Tue, 9 Apr 2024 02:08:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E7AD385842A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E7AD385842A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712628490; cv=none; b=AXVqqEktxLj34pcvRSw2SBlTLp1wFFFpBMvX6OspRzsc/ihENB38RPB5H0LGyN0xZJChcE+Ig9JidWrQSfRB7yXDw95xE91e88TucSPgmFG0VY0AOKkb2FdyVMCNchO4ybyBGCDl9yVSGgrf46ijDpb9P0ojmpiL79IMrpXtqcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712628490; c=relaxed/simple; bh=i0Kl+fUxQolvSTWpA53pqmzEOtkvoi2geKiMuAWVycc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VCFsgQucsy5WGL+T43avGW67Lg0FG0c2aofZi4FaSYdVzOEG22bLOoynIhenAdMXhgawEY66FUD38k6gQeOqd8/ZiMWsQ9z8yMjqj5K1gQBp6LXPt0MOYUAXjp0yEmXpe9p51GFHwCxOTeAlUCpZzRYTV8a5eLtibGcA7EHHNEM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43927f1p028970; Tue, 9 Apr 2024 02:08:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=d9aPFCV6+JisQuTfoRZ87uybEcISqarO02ucv1h7p2Y=; b=pRmaGqlbUeVDSvDEcLKH3DiL0LrFK9s6eojLGLHuajwer31P3xYxJkF7AqLaCVwQ/z1I Hathr462PUMkFhiTNv62qm81Wmk4NbOZJfpuYgqbZv6N9gzifQCy9PMVjh1TjwYlgttp rVw1OD6iw3WDYPLJVuaaFvQM/0qsFHntVM5hiqq+A+bhekSX0rQVMqRndjpsQQUjQCqi mrSN9YntPcHkcJ1GImdjeBhRleUN7JCqPsoj10j5IDJqy0ebscJ6/iRBv44TZ1FoLuID 4+BPES64Iy4AEbRE6nm6sh3o58YJu3cJo7n988Tu8thO11Sd3tiQ/kkD5ayddFu+732+ /w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcune82w9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 02:08:06 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 439285pB029591; Tue, 9 Apr 2024 02:08:05 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcune82w5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 02:08:05 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4391eDB4022583; Tue, 9 Apr 2024 02:08:04 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xbhqnuj39-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2024 02:08:04 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4392801L50921828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Apr 2024 02:08:02 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7A7B72004E; Tue, 9 Apr 2024 02:08:00 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 85F3220040; Tue, 9 Apr 2024 02:07:58 +0000 (GMT) Received: from [9.200.61.88] (unknown [9.200.61.88]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 9 Apr 2024 02:07:58 +0000 (GMT) Message-ID: <42611c0d-b76a-74fd-c4a4-b8a41aa5b556@linux.ibm.com> Date: Tue, 9 Apr 2024 10:07:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614] Content-Language: en-US To: Richard Biener Cc: GCC Patches , j@lambda.is, Peter Bergner , Segher Boessenkool References: From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: iaHOvIy0YWMuq0ExnkFUkjqpECuNSe4T X-Proofpoint-ORIG-GUID: PmGf_FtFSSljZzFgPvcQMXB2llaqk_6a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-08_19,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999 impostorscore=0 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404090010 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2024/4/8 18:47, Richard Biener wrote: > On Mon, Apr 8, 2024 at 11:23 AM Kewen.Lin wrote: >> >> Hi, >> >> As PR114614 shows, the newly added test case gcov-20.c by >> commit r14-9789-g08a52331803f66 failed on targets which do >> not support atomic profile update, there would be a message >> like: >> >> warning: target does not support atomic profile update, >> single mode is selected >> >> Since the test case adopts -fprofile-update=atomic, it >> requires effective target check profile_update_atomic, this >> patch is to add the check accordingly. >> >> Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9 >> and powerpc64le-linux-gnu P9/P10. >> >> Is it ok for trunk? > > OK Thanks, pushed as r14-9851. BR, Kewen > >> BR, >> Kewen >> ----- >> PR testsuite/114614 >> >> gcc/testsuite/ChangeLog: >> >> * gcc.misc-tests/gcov-20.c: Add effective target check >> profile_update_atomic. >> --- >> gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c >> index 215faffc980..ca8c12aad2b 100644 >> --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c >> +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c >> @@ -1,5 +1,6 @@ >> /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */ >> /* { dg-do run { target native } } */ >> +/* { dg-require-effective-target profile_update_atomic } */ >> >> /* Some side effect to stop branches from being pruned */ >> int x = 0; >> -- >> 2.43.0