On 3/29/22 16:47, Tobias Burnus wrote: > On 29.03.22 16:28, Tobias Burnus wrote: > >> On 29.03.22 15:39, Tom de Vries wrote: >>> Any comments? > > I think it would be useful to have additionally some wording for the > (new in GCC 12/new since today) macros, Agreed. > i.e. something like: > > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -27546,6 +27546,10 @@ >  strings must be lower-case.  Valid ISA strings include @samp{sm_30} and >  @samp{sm_35}.  The default ISA is sm_35. > > +This option causes the preprocessor macro @code{__PTX_SM__} to be defined > +to the architecture number multiplied by ten; for instance, for > +@samp{sm_35}, it has the value @samp{350}. > + The macro is defined also if the option is not specified, so I think this formulation is not 100% clear in that aspect. I've reformulated to fix that. Also, I took out the detail of how the value is determined, since we're just following __CUDA_ARCH__ rather than defining our own policy. >  @item -mptx=@var{version-string} >  @opindex mptx >  Generate code for given the specified PTX version (e.g.@: @samp{7.0}). > @@ -27553,6 +27557,10 @@ >  @samp{7.0}.  The default PTX version is 6.0, unless a higher minimal >  version is required for specified PTX ISA via option @option{-misa=}. > > +This option causes the preprocessor macros > @code{__PTX_ISA_VERSION_MAJOR__} > +and @code{__PTX_ISA_VERSION_MINOR__} to be defined; for instance, > +for @samp{3.1} the macros have the values @samp{3} and @samp{1}, > respectively. > + Reformulated this as well. Any comments? Thanks, - Tom