From: Jason Merrill <jason@redhat.com>
To: Patrick Palka <ppalka@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: canonicity of fn types w/ complex eh specs [PR115159]
Date: Tue, 21 May 2024 17:09:48 -0400 [thread overview]
Message-ID: <42726cf3-3bf8-499a-b455-d0181f0b8d3b@redhat.com> (raw)
In-Reply-To: <20240521193629.4129787-1-ppalka@redhat.com>
On 5/21/24 15:36, Patrick Palka wrote:
> Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look
> OK for trunk?
>
> Alternatively, I considered fixing this by incrementing
> comparing_specializations around the call to comp_except_specs in
> cp_check_qualified_type, but generally for types whose identity
> depends on whether comparing_specializations is set we need to
> use structural equality anyway IIUC.
Why not both?
> + bool complex_p = (cr && cr != noexcept_true_spec
> + && !UNPARSED_NOEXCEPT_SPEC_P (cr));
Why treat unparsed specs differently from parsed ones?
Jason
next prev parent reply other threads:[~2024-05-21 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 19:36 Patrick Palka
2024-05-21 21:09 ` Jason Merrill [this message]
2024-05-21 21:27 ` Patrick Palka
2024-05-21 21:31 ` Patrick Palka
2024-05-21 21:36 ` Jason Merrill
2024-05-22 1:55 ` Patrick Palka
2024-05-22 2:58 ` Jason Merrill
2024-05-22 13:01 ` Patrick Palka
2024-05-22 13:38 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42726cf3-3bf8-499a-b455-d0181f0b8d3b@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).