From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 29CE73858D1E for ; Tue, 21 May 2024 21:09:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29CE73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29CE73858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716325794; cv=none; b=KBO6g8WQHVqzTrs8dDU1PIq7KO6inl2rjUn47FRczmJY568THSXhPe8zMNGVQCQBpOIAuk1MEIliXOvO7hK5q92UtDhNqedLB0vfjYUTFb25pSu1gNp6WtJ/cLVXbpSti+3/7I8mKKtBZrc3SB0L5s/hKZakBUdX4pGoWSyLwNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716325794; c=relaxed/simple; bh=nNViQi3aZLqIOVWIqSAM9QShCrBYADQ1ij7Kyktk9vM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=exK19IVFhqXC3cnzxOmZcYbSFxu6+O62q2fN5B7mPZl7zfj2fpGpuKK9SLMm9Jgr+PwI6/tW+ScsZFQypsCD6updk2iwosY5PeVno5ymqL3i59U7Pl8vigzT5f60kb6uwcZbYv8P35WFYBTS/pED9afE/cclA744bGd1sGQlpD4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716325792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UsH+asUEuu9G38uy+bZZMXEQQ7+19dXiqiZa5MEWOMI=; b=YfQjgTySCw4ccXovjcfdbxvelb5mDQACbvHHP/tqeGwQkbKVaWJeR/SFdaA7qQz3Z/Y4pD 0FEgHZpkHIhDFB/3H6JQMHnZunHlUP6ao3Jo/8vBCBmwA0YNRLnUhSs3QEq+cAoGnjf91e 7AuX8aN9lMNZ5girKGBktXyOCT3eV/4= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-d7XF1aHxP-W8fW1N7yum-A-1; Tue, 21 May 2024 17:09:51 -0400 X-MC-Unique: d7XF1aHxP-W8fW1N7yum-A-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-792e34d2884so778447385a.0 for ; Tue, 21 May 2024 14:09:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716325790; x=1716930590; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UsH+asUEuu9G38uy+bZZMXEQQ7+19dXiqiZa5MEWOMI=; b=FKdPhgWJmcBSx5v2i46W8ItlWks3AUXmdgdF5FoMfe7UoE5JpK5mAMf4IoN+1OJQ0V A4qhgXVmm0WaJ4DsCcTry3/+lRQiwjT/nOTkZtsb72jljeC5NXDMUO/uO72i491FEGqA /MlAwXB1bW8n4FLfv25Ya1ye17Agc0bkizr8ila/QTXgd23KdkIWHDhuYXmmVmbabZVU 05g6Dvy1HkCMYyNX/ENCH8b2MPmRrfF7G72ZprEFGWHTINaTRCUFHt4nn/4d+8goYIbs wQofij4UTe04r9JqTMFlisimWqnfQC5XMqBtTdbcHuldKdfzn1c2aVm142Wryfj6Bc4A R5MA== X-Forwarded-Encrypted: i=1; AJvYcCWY50evImiHiamwgVRRpvJKVe/5RRif5H/30eWbqb68i/BSxQY1hTVeDKebgHZfsG98AFJTqhlx5KYgsT8nkNX3F3wZ4qVz5A== X-Gm-Message-State: AOJu0Yw25so2YgyjMN3iz32eMtzO2/HEdtI6euTLgoTQCmN7XNCvtleX rnXOGkrjBn1hyEQUkjLdU/aWHHuiDuLq7C8BJl7VYMo5BEW/a03hEyQdxqmoep3uP/74+mRumso bIcmwpcJ3MMJdkW7eiwh75TNVYhz6qUJzMJ4Mwzloab/B7Vbq7u1EXPe/BIBIUJk= X-Received: by 2002:a05:620a:ec4:b0:792:997f:78f2 with SMTP id af79cd13be357-794994c3aa6mr9956485a.64.1716325790033; Tue, 21 May 2024 14:09:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFB6eADmFmknB8+qkXPatOmnxgn+GCd/UQOihvywHo+w37LC5th6PJ/Pvx3RYp1POJedb/5WQ== X-Received: by 2002:a05:620a:ec4:b0:792:997f:78f2 with SMTP id af79cd13be357-794994c3aa6mr9954885a.64.1716325789636; Tue, 21 May 2024 14:09:49 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf27f992sm1322359885a.36.2024.05.21.14.09.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 14:09:48 -0700 (PDT) Message-ID: <42726cf3-3bf8-499a-b455-d0181f0b8d3b@redhat.com> Date: Tue, 21 May 2024 17:09:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++: canonicity of fn types w/ complex eh specs [PR115159] To: Patrick Palka , gcc-patches@gcc.gnu.org References: <20240521193629.4129787-1-ppalka@redhat.com> From: Jason Merrill In-Reply-To: <20240521193629.4129787-1-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/21/24 15:36, Patrick Palka wrote: > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > OK for trunk? > > Alternatively, I considered fixing this by incrementing > comparing_specializations around the call to comp_except_specs in > cp_check_qualified_type, but generally for types whose identity > depends on whether comparing_specializations is set we need to > use structural equality anyway IIUC. Why not both? > + bool complex_p = (cr && cr != noexcept_true_spec > + && !UNPARSED_NOEXCEPT_SPEC_P (cr)); Why treat unparsed specs differently from parsed ones? Jason