From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-483549-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 94615 invoked by alias); 13 Aug 2018 10:36:34 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 93732 invoked by uid 89); 13 Aug 2018 10:36:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=
X-HELO: mail-it0-f66.google.com
Received: from mail-it0-f66.google.com (HELO mail-it0-f66.google.com) (209.85.214.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Aug 2018 10:36:33 +0000
Received: by mail-it0-f66.google.com with SMTP id d70-v6so11197031ith.1        for <gcc-patches@gcc.gnu.org>; Mon, 13 Aug 2018 03:36:32 -0700 (PDT)
Return-Path: <jason@redhat.com>
Received: from [192.168.1.67] (122-59-124-45-fibre.sparkbb.co.nz. [122.59.124.45])        by smtp.gmail.com with ESMTPSA id y14-v6sm5655844iol.60.2018.08.13.03.36.28        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Mon, 13 Aug 2018 03:36:30 -0700 (PDT)
Subject: Re: [PATCH] convert braced initializers to strings (PR 71625)
To: Martin Sebor <msebor@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>, Joseph Myers <joseph@codesourcery.com>
References: <c9067f6a-9e55-8483-4f4f-c162d4c7a170@gmail.com> <CADzB+2=2Kj=HRLXi1pLx3NGE5XCNRaKjKuG44WeXncCoqrLLdw@mail.gmail.com> <e2bb35fa-7469-df5d-c6e1-fdacbc637155@gmail.com> <CADzB+2kGfD0Qk3wumc0OSsqQtfWUT5yS60T592Sf1Xe=q51Bbg@mail.gmail.com> <e8e7f203-0d7e-7272-a313-33fe93c80b83@gmail.com> <CADzB+2kcuZ2mJHe86wA6PJNo9CWUuRH5+7MoV805ya7_9YjB=w@mail.gmail.com> <b7e6bbd4-b9e8-84ef-8855-d0fc17834a19@gmail.com>
From: Jason Merrill <jason@redhat.com>
Message-ID: <42885b6d-c89b-845e-b807-baa1f4480510@redhat.com>
Date: Mon, 13 Aug 2018 10:36:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <b7e6bbd4-b9e8-84ef-8855-d0fc17834a19@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2018-08/txt/msg00722.txt.bz2

On 08/09/2018 12:17 PM, Martin Sebor wrote:
> Using build_string() rather than build_string_literal() needed
> a tweak in digest_init_r().  It didn't break anything but since
> the array type may not have a domain yet, neither will the
> string.  It looks like that may get adjusted later on but I've
> temporarily guarded the code with #if 1.  If the change is
> fine I'll remove the #if before committing. 

The digest_init_r change seems to follow from allowing STRING_CST of 
signed char, so yes, it's fine.

> +		  && TREE_CODE (init) == CONSTRUCTOR
> +		  && TREE_TYPE (init) == init_list_type_node)

This is BRACE_ENCLOSED_INITIALIZER_P.

OK with that change.

Jason