From: Jeff Law <law@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, middle-end]: Fix PR 88070, ICE in create_pre_exit, at mode-switching.c:438
Date: Tue, 20 Nov 2018 23:46:00 -0000 [thread overview]
Message-ID: <42bfad7f-9899-3244-39bd-3350b387ebe2@redhat.com> (raw)
In-Reply-To: <CAFULd4a6OpcLF6wU24YrEPL0nj2mdo11pHYPj2MTMzp_1T2ucQ@mail.gmail.com>
On 11/19/18 12:58 PM, Uros Bizjak wrote:
> Hello!
>
> The assert in create_pre_exit at mode-switching.c expects return copy
> pair with nothing in between. However, the compiler starts mode
> switching pass with the following sequence:
>
> (insn 19 18 16 2 (set (reg:V2SF 21 xmm0)
> (mem/c:V2SF (plus:DI (reg/f:DI 7 sp)
> (const_int -72 [0xffffffffffffffb8])) [0 S8 A64]))
> "pr88070.c":8 1157 {*movv2sf_internal}
> (nil))
> (insn 16 19 20 2 (set (reg:V2SF 0 ax [orig:91 <retval> ] [91])
> (reg:V2SF 0 ax [89])) "pr88070.c":8 1157 {*movv2sf_internal}
> (nil))
> (insn 20 16 21 2 (unspec_volatile [
> (const_int 0 [0])
> ] UNSPECV_BLOCKAGE) "pr88070.c":8 710 {blockage}
> (nil))
> (insn 21 20 23 2 (use (reg:V2SF 21 xmm0)) "pr88070.c":8 -1
> (nil))
So I know there's an updated patch. But I thought it might be worth
mentioning that insn 16 here appears to be a nop-move. Removing it
might address this instance of the problem, but I doubt it's general
enough to address any larger issues.
You still might want to investigate why it's still in the IL.
Jeff
next prev parent reply other threads:[~2018-11-20 23:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 19:58 Uros Bizjak
2018-11-19 22:42 ` Eric Botcazou
2018-11-20 0:12 ` Uros Bizjak
2018-11-20 7:59 ` Eric Botcazou
2018-11-20 10:25 ` Uros Bizjak
2018-11-20 23:50 ` Jeff Law
2018-11-21 6:54 ` Uros Bizjak
2018-11-20 10:54 ` Uros Bizjak
2018-11-20 23:46 ` Jeff Law [this message]
2018-11-21 9:49 ` Uros Bizjak
2018-11-21 10:03 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42bfad7f-9899-3244-39bd-3350b387ebe2@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).