From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id E6F9D384A87E for ; Thu, 8 Oct 2020 15:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E6F9D384A87E Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-AAwbGPu1NfSeEZgjo95sdQ-1; Thu, 08 Oct 2020 11:09:57 -0400 X-MC-Unique: AAwbGPu1NfSeEZgjo95sdQ-1 Received: by mail-wr1-f71.google.com with SMTP id y3so3990044wrl.21 for ; Thu, 08 Oct 2020 08:09:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OD/v3aEi22V4Jye8tteyCA22twTexQJAicgSAQRAEaw=; b=h4gG+XoyNYUJyeE24Iky2RdV3j1m4N205EGGbUIwc12SHoco1KrQJJ6+QA7/NNYBZo mydWz5UsZDUEBjhG/ZxbMN2iWNIiEo6F9Xy2dqXfkR8S4/fWOZ0846j1ngSY40EPQa07 +NXhpCLCj003uqq6xm3aljUS4VCbxvS1nGwrU3UoFf/vvjnBlvRc9xBPXdY6lV0SWoml CqACnYU1Jv+075+uNq1NzruaKbPgEszFs0MRwPccmPPkzB5mVm7F4jIgiLNcSjjIZJUl Svv1JPZajHECSFWyKeB87+S70IQmANDnj2adtkpQ1d+OvlLMzQ2S9BQA1UsU9H3AZUkv Fjiw== X-Gm-Message-State: AOAM531Ay5S5pSMnG4FZOyzIQWFVmydp2IZOlaSG96j/QnHhDMPpzu6m SdZf5xKl17bBZGZnfvn0JVklmktfH/Krcroi5hVySWhnIHH6m4PhvmBQd8qNHXZMa9zxcwvax9k uuFAN1vt8e/+YDcMMRg== X-Received: by 2002:a1c:9cd3:: with SMTP id f202mr9403791wme.148.1602169795661; Thu, 08 Oct 2020 08:09:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxn5tcyNRUaknnhcYGo9t1uyiFinlDfII/E6hUnFh9yl2C+GyigVsV6ao2wHYO+h0lRhlJ+sA== X-Received: by 2002:a1c:9cd3:: with SMTP id f202mr9403772wme.148.1602169795443; Thu, 08 Oct 2020 08:09:55 -0700 (PDT) Received: from abulafia.quesejoda.com ([95.169.226.213]) by smtp.gmail.com with ESMTPSA id i3sm7733966wrs.4.2020.10.08.08.09.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 08:09:54 -0700 (PDT) Subject: Re: [PATCH] vrp: Fix up gcc.target/aarch64/pr90838.c [PR97312, PR94801] To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Richard Biener References: <20201008102211.GQ2176@tucnak> <20201008135441.GW2176@tucnak> <20201008143959.GX2176@tucnak> <682053fb-fa65-1997-d704-41817753e25a@redhat.com> <20201008150800.GY2176@tucnak> From: Aldy Hernandez Message-ID: <42c5878f-f4d9-3193-7df8-760f041aa02e@redhat.com> Date: Thu, 8 Oct 2020 17:09:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201008150800.GY2176@tucnak> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 15:10:09 -0000 On 10/8/20 5:08 PM, Jakub Jelinek wrote: > On Thu, Oct 08, 2020 at 04:55:07PM +0200, Aldy Hernandez via Gcc-patches wrote: >>> Yes, for max == 0 aka [0, 0] I wanted: >>> 1) if mini == -1, i.e. the DEFINED_VALUE_AT_ZERO == 2 VALUE is -1, return [-1, -1] >>> 2) if maxi == prec, i.e. DEFINED_VALUE_AT_ZERO == 2 VALUE is prec, return [prec, prec] >> >> Ah, I see. Do you mind commenting that? Or perhaps you could spell it out >> obviously like: >> >> if (max == 0) { >> ... >> if (DEFINED_VALUE_AT_ZERO) >> // do special things >> ... >> } >> >> But whatever is fine. I hope to never look at these bits ever again :). > > Added several comments now (but just in gimple-range.cc, I assume > vr-values.c code is what you want to kill eventually). Thanks, and yes... vr-values is on life support :). Aldy