From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 56BC1385840A for ; Fri, 29 Jul 2022 03:51:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56BC1385840A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxL9FOWeNikPZAAA--.3537S2; Fri, 29 Jul 2022 11:51:43 +0800 (CST) Subject: Re: [PATCH v1] LoongArch: Define the macro ASM_PREFERRED_EH_DATA_FORMAT by checking the assembler's support for eh_frame encoding. To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20220729024337.4182683-1-chenglulu@loongson.cn> From: Lulu Cheng Message-ID: <42ccaedd-f4ac-a6d3-4cb9-c564c72bf2c5@loongson.cn> Date: Fri, 29 Jul 2022 11:51:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CM-TRANSID: AQAAf9DxL9FOWeNikPZAAA--.3537S2 X-Coremail-Antispam: 1UD129KBjvJXoW7WryDCw4UZF47trW5trW5Jrb_yoW8Xw13pF y8Cr1DGrWDXr1rKr4DJrW8KFyYyryDGw1UXryrJFW0y3yUAr10qr12gFWq9r1kArZ7Xw1j vF15Kry7urnxAFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUva14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0E x4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACjI8F5V A0II8E6IAqYI8I648v4I1l7480Y4vEI4kI2Ix0rVAqx4xJMxk0xIA0c2IEe2xFo4CEbIxv r21lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I 0E5I8CrVAFwI0_JrI_JrWlx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWU AVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcV CY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjfUoXo2UUUUU X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, BODY_8BITS, HTML_MESSAGE, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 03:51:53 -0000 在 2022/7/29 上午11:18, Xi Ruoyao 写道: > On Fri, 2022-07-29 at 10:43 +0800, Lulu Cheng wrote: > >> .eh_frame DW_EH_PE_pcrel encoding format is not supported by gas <= 2.39. >> Check if the assembler support DW_EH_PE_PCREL encoding and define .eh_frame >> encoding type. >> >> gcc/ChangeLog: >> >>         * config.in: Regenerate. >>         * config/loongarch/loongarch.h (ASM_PREFERRED_EH_DATA_FORMAT): >>         Select the value of the macro definition according to whether >>         HAVE_AS_EH_FRAME_PCREL_ENCODING_SUPPORT is defined. >>         * configure: Regenerate. >>         * configure.ac: Reinstate HAVE_AS_EH_FRAME_PCREL_ENCODING_SUPPORT test. > To me it looks a little strange to list regenerated config.in & > configure before configure.ac. But maybe I'm wrong here if a > lexicographical order is preferred... This information is generated by me through the git gcc-commit-mklog command, then I didn't move the sequence. > > /* snip */ > >> +    gcc_GAS_CHECK_FEATURE([eh_frame pcrel encoding support], >> +      gcc_cv_as_loongarch_eh_frame_pcrel_encoding_support,, >> +      [.LFB1780 = . >> +       .cfi_startproc >> +       .cfi_personality 0x9b,DW.ref.__gxx_personality_v0 >> +       .cfi_lsda 0x1b,.LLSDA1780 >> +       .cfi_endproc],, > I think the conftest content can be simplified to: > > .cfi_startproc > .cfi_personality 0x9b,a > .cfi_lsda 0x1b,b > .cfi_endproc > This one looks more concise, I'll change it