Re: [PATCH] rs6000: Move V2DI vec_neg under power8-vector [PR105271]

["Kewen.Lin" <linkw@linux.ibm.com>]

on 2022/4/26 11:25 PM, Segher Boessenkool wrote:
> On Tue, Apr 26, 2022 at 05:16:18PM +0200, Jakub Jelinek wrote:
>> Hi!
>>
>> On Fri, Apr 15, 2022 at 04:08:15PM +0800, Kewen.Lin via Gcc-patches wrote:
>>> As PR105271 shows, __builtin_altivec_neg_v2di requires option
>>> -mpower8-vector as its pattern expansion relies on subv2di which
>>> has guard VECTOR_UNIT_P8_VECTOR_P (V2DImode).  This fix is to move
>>> the related lines for __builtin_altivec_neg_v2di to the section
>>> of stanza power8-vector.
>>>
>>> Bootstrapped and regtested on powerpc64-linux-gnu P8 and
>>> powerpc64le-linux-gnu P9 and P10.
>>>
>>> Is it ok for trunk?
>>>
>>> BR,
>>> Kewen
>>> -----
>>> 	PR target/105271
>>>
>>> gcc/ChangeLog:
>>>
>>> 	* config/rs6000/rs6000-builtins.def (NEG_V2DI): Move to [power8-vector]
>>> 	stanza.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 	* gcc.target/powerpc/pr105271.c: New test.
>>
>> I'd like to ping this patch, one of the last few remaining P1s we have for
>> GCC 12.
> 
> Heh.  I approved it this morning (off-list).  Kewen will commit it
> soonish (somewhere during your night probably) :-)
> 

Thank you both!  I just committed it as r12-8275.

BR,
Kewen