From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 521273858D32 for ; Thu, 2 Nov 2023 13:48:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 521273858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 521273858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698932904; cv=none; b=QEyji43WCeY0oHBhauMd9zq++eLlxc6ZorzwyLDBif6LAh97JL5bpmgX7wBuK+ce1SIKMwp1hM4DMWvwR5lIvZeVDmLX2mNtkw0ZUuCIUnkInBg/CPd4hipSfz2WxrekKUj4QnxKum0o+UQAp1ZjHB6ZQCgB901fIE2ftmzenLk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698932904; c=relaxed/simple; bh=EQtB5nrxjKA2JLYvBdhzhB4H5mUCewAdCscDxdPOi9U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cM+pEDDJjnvyX2GN6SaiNZhIp2LIi34kzfH/cZT1JB6JttgAr118i+H6h1J6bcQfWbtzqDcqCulQNYKEF/HbmPBWDMTW9qgbxbDrrEPSukbwyeQDF1CkEB01QyFRmNsca8J8B+PN5Z+MERYbTIytWX368xJycbrE97M5xO6wIsY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9c2a0725825so147530366b.2 for ; Thu, 02 Nov 2023 06:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698932902; x=1699537702; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zoum17ZGYizvvLtphXtTvQtPcjT6XuMGe8qPd9BlXuk=; b=eT9VwAL+7lSWVmKepXpeKyBALJYcKF5Qr8rtS8q71pe7bEF/y4QBurFK68r5rw19/i giHWPMGlDBCkG6C+oJNEU/Cdtn6KbH7S6h5m/djmjhZvE15EKRNnAGJT9gIi7hTIHNzN zuLXVDqjuyw3fivcC1hZKz7B3jKU+4oNjmcOmR8n/BqUwcEMOFwa7i6ep3x8KbbmXOLK meLBWO6hl1oyQHKu+EaKoSDxpMoiZpJ8f1LrJnfeNmFg0ncRY3LM69ig9a0E9TMb0dsj 2aXhBa7rRv8O1IenS+fEkaM9aPGc9QvSAJh8ts/uQzOlJAwVXIAK4QuHqAToJZO0Uqee SIMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698932902; x=1699537702; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zoum17ZGYizvvLtphXtTvQtPcjT6XuMGe8qPd9BlXuk=; b=BXaG20l6iIg5KAjYUDPR5JQGdW/pKF3IeC+8MGLukQLVQE2sJH8MI0CWpSvHFe/Hs7 sdmZE6xnID/E4uCAZhgj3wOB6ujik7DcpGdjg2vfEM1YO/kcKauj2CHYV+6lWrJ5vv+k QYqMvJmFIncVeTsRm2a/j7LWbiD8qW4a5es2Hc3RMSeW6RIIh3nuzPVG5kaW5jJ/wlHr YH9o92u/R6fUD28x0r2Rq4jDADT0WaBP+Qe0GjyjZK0oMyw2OFM8ArztKfjsMmTyeomk FqDVFfgIYYYX/n7qPaU/yUW0nLsiku3wnnRsAJsR8f3fsffB1FIZ8kAwxyQfH8KIDmed mmUg== X-Gm-Message-State: AOJu0YztfqzaUuZ+k7Rep1QxxRoqu4YTioLRndHz2U9voyf4nJ8PI9Bg RHDjcRbs8ZmfGvLa574V1ro= X-Google-Smtp-Source: AGHT+IE8nbRBUHNYDUXUpG/TwctcfdqOQZ3PDhpowoxk0J4orc8DrgKqgxcY2YVzouzsxuzg7XLyiA== X-Received: by 2002:a17:907:94cf:b0:9c7:5a01:ffe6 with SMTP id dn15-20020a17090794cf00b009c75a01ffe6mr4357094ejc.13.1698932901685; Thu, 02 Nov 2023 06:48:21 -0700 (PDT) Received: from [192.168.1.23] (ip-046-223-203-173.um13.pools.vodafone-ip.de. [46.223.203.173]) by smtp.gmail.com with ESMTPSA id qh13-20020a170906ecad00b009b29553b648sm1153686ejb.206.2023.11.02.06.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Nov 2023 06:48:21 -0700 (PDT) Message-ID: <430d3b7e-acc3-43bb-9d3e-7897aa7d2e83@gmail.com> Date: Thu, 2 Nov 2023 14:48:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, "richard.sandiford" , gcc-patches , "juzhe.zhong@rivai.ai" Subject: Re: [PATCH] internal-fn: Add VCOND_MASK_LEN. Content-Language: en-US To: Richard Biener References: <818fe7b8-cb55-49d1-94fa-f929b8cbc5d8@gmail.com> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Looks reasonable overall. The new match patterns are 1:1 the > same as the COND_ ones. That's a bit awkward, but I don't see > a good way to "macroize" stuff further there. Can you at least > interleave the COND_LEN_* ones with the other ones instead of > putting them all at the end? Yes, no problem. It's supposed to be only temporary anyway (FWIW) as I didn't manage with the "stripping _LEN" way on the first few tries. Still on the todo list but unlikely to be done before stage 1 closes. I believe Richard "kind of" LGTM'ed the rest minus the spurious pattern (which is gone now) but there is still the direct optab change that he didn't comment on so I think we should wait for his remarks still. Regards Robin