From: "Martin Liška" <mliska@suse.cz>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>
Subject: [PATCH] Cleanup #2 of Pascal references.
Date: Thu, 13 Jul 2017 08:10:00 -0000 [thread overview]
Message-ID: <430e7605-e428-3358-b344-e8e1d4c151be@suse.cz> (raw)
In-Reply-To: <CADzB+2mpKwdq7-A2wXA-iZSfsrwLAtBQKwe5M6yqSOisW-vhew@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 61 bytes --]
Thanks Jason, I'm sending patch #2.
Ready for trunk?
Martin
[-- Attachment #2: 0001-Cleanup-2-of-Pascal-references.patch --]
[-- Type: text/x-patch, Size: 3038 bytes --]
From 2fa6d00cc6686e8bf081d736de44c22ecf61a795 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Thu, 13 Jul 2017 10:08:14 +0200
Subject: [PATCH] Cleanup #2 of Pascal references.
gcc/ChangeLog:
2017-07-13 Martin Liska <mliska@suse.cz>
* dwarf2out.c (gen_pointer_type_die): Remove dead code.
(gen_reference_type_die): Likewise.
* stor-layout.c: Remove Pascal-related comment.
---
gcc/dwarf2out.c | 40 ----------------------------------------
gcc/stor-layout.c | 3 +--
2 files changed, 1 insertion(+), 42 deletions(-)
diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index 9357a100f6a..e50428e4e31 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -23293,46 +23293,6 @@ gen_field_die (tree decl, struct vlr_context *ctx, dw_die_ref context_die)
equate_decl_number_to_die (decl, decl_die);
}
-#if 0
-/* Don't generate either pointer_type DIEs or reference_type DIEs here.
- Use modified_type_die instead.
- We keep this code here just in case these types of DIEs may be needed to
- represent certain things in other languages (e.g. Pascal) someday. */
-
-static void
-gen_pointer_type_die (tree type, dw_die_ref context_die)
-{
- dw_die_ref ptr_die
- = new_die (DW_TAG_pointer_type, scope_die_for (type, context_die), type);
-
- equate_type_number_to_die (type, ptr_die);
- add_type_attribute (ptr_die, TREE_TYPE (type), TYPE_UNQUALIFIED, false,
- context_die);
- add_AT_unsigned (mod_type_die, DW_AT_byte_size, PTR_SIZE);
-}
-
-/* Don't generate either pointer_type DIEs or reference_type DIEs here.
- Use modified_type_die instead.
- We keep this code here just in case these types of DIEs may be needed to
- represent certain things in other languages (e.g. Pascal) someday. */
-
-static void
-gen_reference_type_die (tree type, dw_die_ref context_die)
-{
- dw_die_ref ref_die, scope_die = scope_die_for (type, context_die);
-
- if (TYPE_REF_IS_RVALUE (type) && dwarf_version >= 4)
- ref_die = new_die (DW_TAG_rvalue_reference_type, scope_die, type);
- else
- ref_die = new_die (DW_TAG_reference_type, scope_die, type);
-
- equate_type_number_to_die (type, ref_die);
- add_type_attribute (ref_die, TREE_TYPE (type), TYPE_UNQUALIFIED, false,
- context_die);
- add_AT_unsigned (mod_type_die, DW_AT_byte_size, PTR_SIZE);
-}
-#endif
-
/* Generate a DIE for a pointer to a member type. TYPE can be an
OFFSET_TYPE, for a pointer to data member, or a RECORD_TYPE, for a
pointer to member function. */
diff --git a/gcc/stor-layout.c b/gcc/stor-layout.c
index 1574e4383e8..f733b1e4609 100644
--- a/gcc/stor-layout.c
+++ b/gcc/stor-layout.c
@@ -2647,8 +2647,7 @@ set_min_and_max_values_for_integral_type (tree type,
/* Set the extreme values of TYPE based on its precision in bits,
then lay it out. Used when make_signed_type won't do
- because the tree code is not INTEGER_TYPE.
- E.g. for Pascal, when the -fsigned-char option is given. */
+ because the tree code is not INTEGER_TYPE. */
void
fixup_signed_type (tree type)
--
2.13.2
next prev parent reply other threads:[~2017-07-13 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 14:30 [PATCH] Remove Pascal language in source code Martin Liška
2017-07-11 14:42 ` [RFC] Remaining references of Pascal Martin Liška
2017-07-11 15:57 ` Jason Merrill
2017-07-13 8:10 ` Martin Liška [this message]
2017-07-13 13:37 ` [PATCH] Cleanup #2 of Pascal references Jason Merrill
2017-07-13 14:59 ` [PATCH] Remove Pascal language in source code Jeff Law
2017-07-13 16:07 ` Pedro Alves
2017-07-14 7:05 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430e7605-e428-3358-b344-e8e1d4c151be@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).