From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Restore RTL alias analysis for hard frame pointer
Date: Wed, 9 Nov 2022 11:44:17 +0100 [thread overview]
Message-ID: <43366F89-C9B8-4F5D-8E45-4BE7C123837B@gmail.com> (raw)
In-Reply-To: <21665502.EfDdHjke4D@fomalhaut>
> Am 09.11.2022 um 10:49 schrieb Eric Botcazou <botcazou@adacore.com>:
>
>
>>
>> Oh, do you have a testcase suitable for the testsuite?
>
> C guality testcase attached, it fails on x86/Linux with -m32 on the gcc-12
> branch (which does not have the fix):
>
> FAIL: gcc.dg/guality/param-6.c -O1 -DPREVENT_OPTIMIZATION line 15 i == 5
> FAIL: gcc.dg/guality/param-6.c -O2 -DPREVENT_OPTIMIZATION line 15 i == 5
> FAIL: gcc.dg/guality/param-6.c -O3 -g -DPREVENT_OPTIMIZATION line 15 i ==
> 5
> FAIL: gcc.dg/guality/param-6.c -Os -DPREVENT_OPTIMIZATION line 15 i == 5
> FAIL: gcc.dg/guality/param-6.c -O2 -flto -fno-use-linker-plugin -flto-
> partition=none -DPREVENT_OPTIMIZATION line 15 i == 5
> FAIL: gcc.dg/guality/param-6.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-
> objects -DPREVENT_OPTIMIZATION line 15 i == 5
>
> but passes on the mainline (which has the fix) and on the gcc-11 branch (which
> does not have the issue). The fix also eliminates other regressions:
>
> -FAIL: gcc.dg/guality/drap.c -Os -DPREVENT_OPTIMIZATION line 21 a == 5
> -FAIL: gcc.dg/guality/drap.c -Os -DPREVENT_OPTIMIZATION line 22 b == 6
> -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 35 v ==
> 1
> -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 36 e ==
> &a[1]
> -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 40 v ==
> 1
> -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 41 e ==
> &a[1]
> -FAIL: gcc.dg/guality/pr43177.c -Os -DPREVENT_OPTIMIZATION line 15 x == 7
> -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 20 y ==
> 25
> -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 20 z ==
> 6
> -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 23 y ==
> 117
> -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 23 z ==
> 8
> -FAIL: gcc.dg/guality/pr54519-4.c -Os -DPREVENT_OPTIMIZATION line 17 y ==
> 25
> -FAIL: gcc.dg/guality/pr54796.c -O1 -DPREVENT_OPTIMIZATION line 17 a == 5
> -FAIL: gcc.dg/guality/pr54796.c -O1 -DPREVENT_OPTIMIZATION line 17 b == 6
> -FAIL: gcc.dg/guality/pr54796.c -O1 -DPREVENT_OPTIMIZATION line 17 c == 5
> -FAIL: gcc.dg/guality/pr54796.c -O2 -DPREVENT_OPTIMIZATION line 17 a == 5
> -FAIL: gcc.dg/guality/pr54796.c -O2 -DPREVENT_OPTIMIZATION line 17 b == 6
> -FAIL: gcc.dg/guality/pr54796.c -O2 -DPREVENT_OPTIMIZATION line 17 c == 5
> -FAIL: gcc.dg/guality/pr54796.c -O3 -g -DPREVENT_OPTIMIZATION line 17 a ==
> 5
> -FAIL: gcc.dg/guality/pr54796.c -O3 -g -DPREVENT_OPTIMIZATION line 17 b ==
> 6
> -FAIL: gcc.dg/guality/pr54796.c -O3 -g -DPREVENT_OPTIMIZATION line 17 c ==
> 5
> -FAIL: gcc.dg/guality/pr54796.c -Os -DPREVENT_OPTIMIZATION line 17 a == 5
> -FAIL: gcc.dg/guality/pr54796.c -Os -DPREVENT_OPTIMIZATION line 17 b == 6
> -FAIL: gcc.dg/guality/pr54796.c -Os -DPREVENT_OPTIMIZATION line 17 c == 5
> -FAIL: gcc.dg/guality/pr54796.c -O2 -flto -fno-use-linker-plugin -flto-
> partition=none -DPREVENT_OPTIMIZATION line 17 a == 5
> -FAIL: gcc.dg/guality/pr54796.c -O2 -flto -fno-use-linker-plugin -flto-
> partition=none -DPREVENT_OPTIMIZATION line 17 b == 6
> -FAIL: gcc.dg/guality/pr54796.c -O2 -flto -fno-use-linker-plugin -flto-
> partition=none -DPREVENT_OPTIMIZATION line 17 c == 5
> -FAIL: gcc.dg/guality/sra-1.c -Os -DPREVENT_OPTIMIZATION line 43 a.j == 14
> -FAIL: gcc.dg/guality/vla-1.c -O1 -DPREVENT_OPTIMIZATION line 24 i == 5
> -FAIL: gcc.dg/guality/vla-1.c -O2 -DPREVENT_OPTIMIZATION line 24 i == 5
> -FAIL: gcc.dg/guality/vla-1.c -O3 -g -DPREVENT_OPTIMIZATION line 24 i == 5
> -FAIL: gcc.dg/guality/vla-1.c -Os -DPREVENT_OPTIMIZATION line 24 i == 5
> -FAIL: gcc.dg/guality/vla-1.c -O2 -flto -fno-use-linker-plugin -flto-
> partition=none -DPREVENT_OPTIMIZATION line 24 i == 5
>
> present on the gcc-12 branch wrt the gcc-11 branch (apparently nobody really
> cares about the guality testsuite on x86/Linux).
Thanks a lot, OK.
Richard
>
>
> * gcc.dg/guality/param-6.c: New test.
>
> --
> Eric Botcazou
> <param-6.c>
prev parent reply other threads:[~2022-11-09 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 9:10 Eric Botcazou
2022-10-28 12:27 ` Richard Biener
2022-10-28 12:27 ` Richard Biener
2022-10-29 8:19 ` Eric Botcazou
2022-10-29 11:03 ` Richard Biener
2022-11-09 9:47 ` Eric Botcazou
2022-11-09 10:44 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43366F89-C9B8-4F5D-8E45-4BE7C123837B@gmail.com \
--to=richard.guenther@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).