From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 3A5683858D28 for ; Sun, 7 May 2023 15:23:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A5683858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-250252e4113so1909638a91.0 for ; Sun, 07 May 2023 08:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683473038; x=1686065038; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cdKZEIDd4G4xygwsq1PqBBEF9NEKwah58lVZoYigQso=; b=NgW9SMiCCQ3PcUtvkzLTqkVrx6cq2tk5mwfp0hRnShdJXO7grR7X6pL5sZF83A6aRK S8p9yxtBgTnhLCy/ARSyFfFStgrGGMa8/91So/FbeABWQ7ZVQqr3LJgLleyeToWHbn4v icAImj+aO0C9mOoU8E53zZPRkiCU6+TuKVwXfBXwtFvGvhAKM1HcLcTqYs7j10qVJhC6 5GZXVIcwKBKaIBf/QV3akziDhqAaH9umbeWxtJxHgbW6Y0DersheZDoajGViYfnkn7l3 f87Xi8ezHJDxnpkc978Yw94Si5nRCLykU2DeYhlHtLFgblzSWZDA8z3Bnvt4B277kbvt jkgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683473038; x=1686065038; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdKZEIDd4G4xygwsq1PqBBEF9NEKwah58lVZoYigQso=; b=WNhqY78RmcPUklvRulnSEl7irKFCGl3PKi2XndxlRKxFyxDFyOSnodeTQjuLOsHZxW s4XMs5UBpuzELRBcz0Ft7jryhKs6iR/2zBMa1gbXpfGIw6q/RoVGA9TUtuCmXWOS8KKw Srw0rS0sVLuHBo3uIR92TZMDsvKM4/24ODieKvuM+RUKlQJfnAT+Rj09zHwY3RK6O5Z6 vHQ1iggSvaV1gQbzIW5hoeMokP+4tiVYv/d8sZdu4Axv085g/BAjst2oCFFYlxMg6gJE aWuEPNDfnZi8AR3ENGsfJIjmfNvz4P5KTR1jk98lEGTqN+JCDrLt0xQC1ExP+lgKlLbu HRKg== X-Gm-Message-State: AC+VfDygWpNvquG3HIeHTfDg0teiLil4DZL4qWHHV9I68XVtaHFkWwQh YeC1qVlqrqHnU9M2su0+wzzrdFe0c3M= X-Google-Smtp-Source: ACHHUZ4/yzvhUGb/Nu0klboTclOEX4Ki+p0PBwkMGa5VconP2kg31FO7AAKbwnVGsuHM8OAsqBeN4w== X-Received: by 2002:a17:90a:9901:b0:24e:102e:edbf with SMTP id b1-20020a17090a990100b0024e102eedbfmr8386745pjp.13.1683473038000; Sun, 07 May 2023 08:23:58 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id o4-20020a170902d4c400b001a2135e7eabsm5320105plg.16.2023.05.07.08.23.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 08:23:57 -0700 (PDT) Message-ID: <436847c8-0c15-24de-5925-f56d78caf540@gmail.com> Date: Sun, 7 May 2023 09:23:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] machine_mode type size: Extend enum size from 8-bit to 16-bit Content-Language: en-US To: "Li, Pan2" , Kito Cheng Cc: "juzhe.zhong@rivai.ai" , rguenther , "richard.sandiford" , gcc-patches , palmer , jakub References: <20230410144808.324346-1-juzhe.zhong@rivai.ai> <2978624D57874251+2023041307225185723242@rivai.ai> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/6/23 19:55, Li, Pan2 wrote: > It looks like we cannot simply swap the code and mode in rtx_def, the code may have to be the same bits as the tree_code in tree_base. Or we will meet ICE like below. > > rtx_def code 16 => 8 bits. > rtx_def mode 8 => 16 bits. > > static inline decl_or_value > dv_from_value (rtx value) > { > decl_or_value dv; > dv = value; > gcc_checking_assert (dv_is_value_p (dv)); <= ICE > return dv; Ugh. We really just need to fix this code. It assumes particular structure layouts and that's just wrong/dumb. So I think think the first step is to fix up this crap code in var-tracking. That should be a patch unto itself. Then we'd have the structure changes as a separate change. Jeff