From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18590 invoked by alias); 17 Feb 2006 10:34:40 -0000 Received: (qmail 18578 invoked by uid 22791); 17 Feb 2006 10:34:39 -0000 X-Spam-Check-By: sourceware.org Received: from usilu-ge.ti-edu.ch (HELO mail.usilu.net) (195.176.176.226) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Feb 2006 10:34:37 +0000 Received: from [192.168.76.117] ([192.168.76.117] RDNS failed) by mail.usilu.net over TLS secured channel with Microsoft SMTPSVC(6.0.3790.1830); Fri, 17 Feb 2006 11:37:32 +0100 Message-ID: <43F5A6BF.70206@lu.unisi.ch> Date: Fri, 17 Feb 2006 10:34:00 -0000 From: Paolo Bonzini User-Agent: Thunderbird 1.5 (Macintosh/20051201) MIME-Version: 1.0 To: Zdenek Dvorak CC: gcc-patches@gcc.gnu.org, Roger Sayle Subject: Re: Patch ping References: <20060216155808.GA7757@atrey.karlin.mff.cuni.cz> <20060217092446.GA18805@atrey.karlin.mff.cuni.cz> In-Reply-To: <20060217092446.GA18805@atrey.karlin.mff.cuni.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2006-02/txt/msg01407.txt.bz2 >> Similar double word arithmetic routines >> are already duplicated in the tree-ssa optimizers. The middle-end >> handling of TREE_OVERFLOW/TREE_CONSTANT_OVERFLOW and representation >> of INTEGER_CST, REAL_CST, CONST_INT and CONST_DOUBLE in trees and >> RTL are already "weeping sores" in GCC's infrastructure. Rather >> than add another set of hacks, or get embroiled in the inevitable >> clean-up, might I recommend using HOST_WIDE_INT pairs for the time >> being? While I agree on the code duplication issues, on the other hand, I like the struct double_int much more than HOST_WIDE_INT pairs. Don't hold your breath, but if Zdenek's patch goes in I might work on using his struct double_int in fold-const.c as well. That's probably 4.3. Paolo