From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 2EB553A78014 for ; Wed, 28 Apr 2021 16:06:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2EB553A78014 Received: by mail-pg1-x534.google.com with SMTP id b17so8042744pgh.7 for ; Wed, 28 Apr 2021 09:06:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=SIn+aIS9w7WY/9588SCAMGGm8F7HjowFCAbhsxwR5fw=; b=jTJBZ4qzUOZCrIfcb3rLTKC2+q+9DvcUgOmLzjrIBrxDtfJfu/4XSp+czpyK+D0QN4 mY90UqGubtaVPSGODn8tWJjbogPvDRCXuPIR3Q0jfzZfC8WIufP8a2qoAXGLREnFjprF XE6jTusZDgci0FInFz40CYwtGoqS0PmrzuZi4TGpXwpnB/BVuB6BlcNO12KftwdKDJrw cZYs1qQvFy1nS+39EawZIsl10GmcKdyl2oA/NoR3iEg7rQ7jG5C+7Z5u7Hv55uwqK+4d 0eYbQbM4GBVmHixCK6nuQQUwYHpMvE6BwFRQBcCesgJ99nrU2OEmcXK1vC2lLrF89kFS 2QMw== X-Gm-Message-State: AOAM532nuiGY3qAY+bnD/TWAPBezRy5HrIzFPsdgeNk2eaFSua8H5wWK OqHc7TohvFSTAqjdnmOg1ILB6tWuBoOj3g== X-Google-Smtp-Source: ABdhPJwwh2NCsSbNDpvGWa8X9XIF5xq0L5sA5v41F5uYnKH0q2NQSy/1xzv+l7pXQdzgx46Phfxr9Q== X-Received: by 2002:a63:6c06:: with SMTP id h6mr28381708pgc.95.1619625996084; Wed, 28 Apr 2021 09:06:36 -0700 (PDT) Received: from [192.168.1.29] (65-130-82-141.slkc.qwest.net. [65.130.82.141]) by smtp.gmail.com with ESMTPSA id d4sm173388pgv.1.2021.04.28.09.06.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 09:06:35 -0700 (PDT) Subject: Re: [PATCH v2 16/21] libcc1: use GCC_FE_VERSION_1 in C++ plugin To: Tom Tromey , gcc-patches@gcc.gnu.org References: <20210428010119.806184-1-tom@tromey.com> <20210428010119.806184-17-tom@tromey.com> From: Jeff Law Message-ID: <43abf6e3-708d-ff58-5423-2157fcb24891@gmail.com> Date: Wed, 28 Apr 2021 10:06:35 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210428010119.806184-17-tom@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 16:06:38 -0000 On 4/27/2021 7:01 PM, Tom Tromey wrote: > The C++ plugin defaults to version 0 of the base compiler API. > However, this is a mistake -- version 1 was introduced before the C++ > API was even implemented. This switches the default to version 1. > Note that the compiler-side plugin will accept this version, so it > should remain compatible. > > libcc1/ChangeLog > 2021-04-27 Tom Tromey > > * libcp1.cc (vtable): Use GCC_FE_VERSION_1. OK Jeff