From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 0ACE23853835 for ; Thu, 6 Oct 2022 02:48:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0ACE23853835 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x431.google.com with SMTP id y136so840394pfb.3 for ; Wed, 05 Oct 2022 19:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=UP7mlMewRmcHq1dl/KaHdZ4TWG9u4Gkro9Vp7drdQWE=; b=iLMVJP+i2DeiH/gXxaW3GYYXtua8G7Ugay/gUV5TmcDjzU1vooGVuOwkx4kgr1BqCN LB0gpx+xQi+C4spCEegxggAgFmXhBBK+I5h5yIRH92RU7sYZeWvsil2oT2PVOSXH11tj a2d753eAfQ5YZU9whsa+kzmas++XbtEq4IxYcAfkzC21EpMwGhwMkAE+8GjrloN9T3AV aW0auIeAtOG9nijskWL0XUUGHRcDweUjx4Y661Dz1fNH6s4wFb31p6q1Wo4B86vMnXuq oNtEkHfIMYDdIVnJLTRIxpCNrfVmFq9xdE+edY5ySlOQimv6dCFZQ2wxo6q5SekvhD7q 8ZkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=UP7mlMewRmcHq1dl/KaHdZ4TWG9u4Gkro9Vp7drdQWE=; b=eJzgqjD//4Y5KlxI9MqSNXurEpDYx548hIuysh/ha0wDevuJVo509qx9mHyiw1+awC PDtr7g5qWcMFWF2F6Z6s6PLo8mRCM7GXeIsC8D28BDgXjP9XVS+ysUGuLNjOnnCfUQ2o f8RBqEDyo23ZxxVzbrdnTqAmn5Hi9b+889cUzcRAE+RJDIuxZT2modUjxP2c5fSaGQg6 GYvqyJloUzWD2XTIqFAp6S5C8DkKmRWyS+UQ59NpDwRIy3atiPEnAX5A5Hjofj8X8Fcc iJxl46szw5ea6WRZV72BgfJzoi/IyItQh2xHhZ6oHxD44tNR3DbYtaHhvWKNCyrbhiwT jPtw== X-Gm-Message-State: ACrzQf1Y3OrtiK7xbtVCqT5S78JCEzK3nF/HUyuZ6FFiYRQp5PQbpx1t +41286AjNRYTyA37SBjedUhYccs/wAIdNw== X-Google-Smtp-Source: AMsMyM6R8h8OFRqTxAlJq01x1DGOOuwKQh4kDFv1lcjhCwcPG859JVxdItMOkePniWM9vW1Ye9QWVQ== X-Received: by 2002:a63:6c41:0:b0:457:7295:818a with SMTP id h62-20020a636c41000000b004577295818amr2513691pgc.615.1665024494639; Wed, 05 Oct 2022 19:48:14 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d137-20020a621d8f000000b00528a097aeffsm11618195pfd.118.2022.10.05.19.48.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 19:48:14 -0700 (PDT) Message-ID: <43be68a9-3069-26eb-8b1a-4f9215e02f8d@gmail.com> Date: Wed, 5 Oct 2022 20:48:13 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] cselib: Skip BImode while keeping track of subvalue relations [PR107088] Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20221004112849.27678-1-stefansf@linux.ibm.com> From: Jeff Law In-Reply-To: <20221004112849.27678-1-stefansf@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/4/22 05:28, Stefan Schulze Frielinghaus via Gcc-patches wrote: > For BImode get_narrowest_mode evaluates to QImode but BImode < QImode. > Thus FOR_EACH_MODE_UNTIL never reaches BImode and iterates until OImode > for which no wider mode exists so we end up with VOIDmode and fail. > Fixed by adding a size guard so we effectively skip BImode. > > Bootstrap and regtest are currently running on x64. Assuming they pass > ok for mainline? > > gcc/ChangeLog: > > PR rtl-optimization/107088 > * cselib.cc (new_cselib_val): Skip BImode while keeping track of > subvalue relations. OK.  And FWIW, this fixes the various failures I saw in my tester due to the cselib patches. jeff