From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 624EE3858401 for ; Wed, 5 Jun 2024 19:33:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 624EE3858401 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 624EE3858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717616033; cv=none; b=xHaOx5YO+bEa62OS8X384kcESrKnZjd+mUGGCtntyJzopkmI0o/AKgzvJGd0T2cpEyTav5WzflMGuKcEnpRe3yW3sNm8Yr22NaWelpXDxcRQfZQTgWFrtWqS6BmUppWpu29cf9dANMvGz2jouz8/NXrP6FprvRpHOXNcZuy6DMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717616033; c=relaxed/simple; bh=2yjHBPedjJfSiokrVFLSNvGO/4XiSYnDlt8c/FkFtzg=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=p3fMUF6jTQHOhIFw/EIB0Ds9vF/8p/iM1ObWnJP2+sg2acX4HuvcSfFcRfh8X/W9gItJw+si5iscKvzHMg6NYAs2gCooHLxjVj1W3phQI+Yhk2kq5LZyPBmDoA9Fp4uttgeJo4YHTHtk//551KeDEqEko5fnia3q96Dlxmwb57I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-35e4d6f7c5cso139348f8f.2 for ; Wed, 05 Jun 2024 12:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1717616030; x=1718220830; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p0fWzhHpdV5t8qY56lzRset4cUoq43EV6DVLEaSjAT4=; b=dik/D5uixkyNolzKCJySx5eNVKE0pxBvMr8yAPUh9NSe/z1fGgrFPKh7jrB1soXwTv uECYVSOhZ5cByIrLohz06W4oyIFaXTmiApvs2p8Q9b8qsQ/3APTVHnYqu4mD68QGsNim qAHsLcpGh+zjDWvuvkeNjjmBDRK1dZmxvrBeDTrPn9FbN+FCqmH1lpPdUIPtPe3hM7LM vWGykNpX6rZ4JcPCLTzU0kJCQjVjk4MxVj+QtxzJf4egBHkgcxfRl1alJ7ygDDsjn+pf E0CKco4qiNa2AO6fd+EZZ7xXb8fXKo9virK27TqDJHgmxwP6Qzr9IUkVS10kXVf0XqTm LTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717616030; x=1718220830; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p0fWzhHpdV5t8qY56lzRset4cUoq43EV6DVLEaSjAT4=; b=pia94HtEwoHeFbCqs4SJ6SDG4c6n9VyTr8AhnjUlPo4WjYkSFeVwrk7YMCav4RxpM+ x0jADTZSIzchFZtrP4fHoBg3pfktiWI15XSNfwnXQZHYs7PyaaURbuTnnA6fookZeUun 3ElNbOBRX7ZcWyyK2jTNxdg1AhF/F3CmySA7J82SDPUn6O1dgONgZUER3XJ3LWsTSXOZ LFVJTLNYgwwu+yzuOogZ9MFC285lQO+mhXarP1xA/jzXz33DYFIGV/uXVaDtPGHrkfUy 38J88xkAftevSshghMRuI74/du0WmaBZw6jEFFEBuO+wGE0LrlsySRFEQKf3wuYwU46z d2HQ== X-Forwarded-Encrypted: i=1; AJvYcCWy1dPuCrz9lavYB6YfOd++ivvNbhPloWMnFbbA+swfEIwTy6UwDIPafPUgTIlrC4zHWb//kCErkjFFCD8mBUJBGwIZ/a4LqQ== X-Gm-Message-State: AOJu0YxQ7Y58WNoabCzyAwz6IAofwJoxPcdAo8OrclRJQ278WzEP/hMZ wNj5SenGDjlHDd4SvU1v6F/FBOAVeNuL/nN4QLe4eszWD1SE2jNDX3uG9Wz67Q== X-Google-Smtp-Source: AGHT+IG0GLRkVZgD9QY72wX4o1cefVC8jG3oVmD4X/Iu0pSGnCvyMtxNmLJiMgzLCZDT6AAQ6Ru2hA== X-Received: by 2002:adf:fc0a:0:b0:355:230:e2d3 with SMTP id ffacd0b85a97d-35e840677cemr2434407f8f.20.1717616029962; Wed, 05 Jun 2024 12:33:49 -0700 (PDT) Received: from smtpclient.apple (2a01cb0013d650006d0e040d4ce83fac.ipv6.abo.wanadoo.fr. [2a01:cb00:13d6:5000:6d0e:40d:4ce8:3fac]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35e0f97ba3csm15285334f8f.73.2024.06.05.12.33.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2024 12:33:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v2] [libstdc++] add _GLIBCXX_CLANG to workaround predefined __clang__ From: Olivier Hainque In-Reply-To: Date: Wed, 5 Jun 2024 21:33:48 +0200 Cc: Olivier Hainque , Alexandre Oliva , Jonathan Wakely , libstdc++ , gcc-patches@gcc.gnu.org, Matthias Kretz Content-Transfer-Encoding: 7bit Message-Id: <440EF2B7-6466-47AF-8937-3AE4C0FBFBE5@adacore.com> References: To: Jakub Jelinek , Jonathan Wakely X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>> Here's what I've retested on x86_64-linux-gnu and, slightly adjusted for >>> gcc-13, on arm-vx7r2. Ok to install? >> >> OK Thanks Jonathan! >> If there's any chance of getting the vxworks system headers fixed to >> work with GCC properly, that would be nice. That would be nice for sure. From the vendor end, that seems very unlikely, unfortunately: VxWorks, for a variety of targets, used to come with both gcc and llvm system toolchains, with active support for the two possibilities in system headers. Also Diab to some extent. Over the years, even if there are still bits around in some headers, active support for gnu toolchains was removed and I don't see that it will be reintroduced. Jakub suggested: > Fixincludes? > That seems like the standard way to workaround bugs in system headers on > proprietary targets. Indeed, although we'd really rather avoid relying on that as much/as long as we reasonably can due to a few specifities of common VxWorks setups. Since VxWorks 7, for a given base distrib for a target environment, different users or projects configure kernels specifically to include such or such feature, and this tailors the exposed set of system headers. Relying on fixincludes would require installing an instance of gcc for each such configuration, resinstalling (or re-mkheaders) every time a kernel configuration change takes place, on hosts where users might need to go through sysadmins for compiler updates. This would be, I'm afraid, a significant regression in usability. Olivier