From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24196 invoked by alias); 15 Mar 2006 10:23:20 -0000 Received: (qmail 24187 invoked by uid 22791); 15 Mar 2006 10:23:19 -0000 X-Spam-Check-By: sourceware.org Received: from petasus.ims.intel.com (HELO petasus.ims.intel.com) (62.118.80.130) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Mar 2006 10:23:19 +0000 Received: from [10.125.250.61] (gzagorod-mobl.ccr.corp.intel.com [10.125.250.61]) by petasus.ims.intel.com (8.12.9-20030918-01/8.12.10/d: small-solo.mc,v 1.2 2004/09/17 18:05:04 root Exp $) with ESMTP id k2FAbn6K007535; Wed, 15 Mar 2006 10:37:51 GMT Message-ID: <4417EB02.9020107@linux.intel.com> Date: Wed, 15 Mar 2006 10:23:00 -0000 From: Grigory Zagorodnev User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Steve Ellcey CC: gcc-patches@gcc.gnu.org, uttamp@us.ibm.com, roger@eyesopen.com Subject: Re: Patch ping References: <200603141649.IAA14478@hpsje.cup.hp.com> In-Reply-To: <200603141649.IAA14478@hpsje.cup.hp.com> Content-Type: multipart/mixed; boundary="------------040600070403050208090303" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2006-03/txt/msg00920.txt.bz2 This is a multi-part message in MIME format. --------------040600070403050208090303 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Content-length: 711 Steve Ellcey wrote: > I think that this patch may be breaking the IA64 bootstrap (HP-UX and > I am guessing this may be related to the change made to > identify_predicable_attribute. Is anyone seeing this? Hi! I do see the same on ia64 trunk builds since this commit. Arm build failures are expected as well because attribute "predicable" is used there too. It seems to be wrong to free p_false memory at the end of 'identify_predicable_attribute' routine when it returns with success - the pointer is assigned to predicable_true and predicable_false variables for the future use. Therefore there is no memory leak. The fix is just back out a part of original commit. Do you think it is ok? - Grigory --------------040600070403050208090303 Content-Type: text/plain; name="gensupport.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gensupport.c.patch" Content-length: 366 Index: gcc/gensupport.c =================================================================== --- gcc/gensupport.c (revision 112077) +++ gcc/gensupport.c (working copy) @@ -511,9 +511,6 @@ identify_predicable_attribute (void) value); errors = 1; } - - if (p_false) - free (p_false); } /* Return the number of alternatives in constraint S. */ --------------040600070403050208090303--