From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21828 invoked by alias); 10 Dec 2014 11:31:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21814 invoked by uid 89); 10 Dec 2014 11:31:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Dec 2014 11:31:26 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id E0D252BC0067; Wed, 10 Dec 2014 12:31:22 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pxe_EfBJ-J9t; Wed, 10 Dec 2014 12:31:22 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id B9BCB2BC002F; Wed, 10 Dec 2014 12:31:22 +0100 (CET) From: Eric Botcazou To: Martin Jambor Cc: gcc-patches@gcc.gnu.org, Richard Biener Subject: Re: [patch] Fix ICE on unaligned record field Date: Wed, 10 Dec 2014 11:31:00 -0000 Message-ID: <4436361.dk8FqIIdMT@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <20141203140207.GL8214@virgil.suse> References: <3887233.jQSJCmu5YU@polaris> <20141203140207.GL8214@virgil.suse> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2014-12/txt/msg00904.txt.bz2 > I suppose that could be done by something like the following, which I > have tested only very mildly so far, in particular I have not double > checked that get_inner_reference is cfun-agnostic. Thanks, this works fine on the testcase and I believe that get_inner_reference is indeed cfun-agnostic (for example it's called from front-ends). > 2014-12-03 Martin Jambor > > * tree-sra.c (ipa_sra_check_caller_data): New type. > (has_caller_p): Removed. > (ipa_sra_check_caller): New function. > (ipa_sra_preliminary_function_checks): Use it. If Richard and you think it's the way to go, then fine by me. -- Eric Botcazou