From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 10CD93858D1E for ; Sat, 11 Mar 2023 15:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10CD93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x436.google.com with SMTP id z11so5373117pfh.4 for ; Sat, 11 Mar 2023 07:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678549335; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/xmfn18hkN0OkaR4hcCpyZSJ1ppveeCqgILhTv/NVSw=; b=eGUPpubREmQgFcyqt8A74MkBj1i3teJVHx6hLzbRnxyGjCwy7MSxq5n6zlw7pKg0v4 Y/m3Gpw7NcqqsvsLxZQbQMs4laNvJq0sEQljBGWptPlZqcvxXCr9DapNguGvqN0Qe1Rt Zd13GPv9+sXHpTYyXjYeDhhYjXPnS34hkXcgDZHaanzNSFdprR8G+gpZhaZIlwJic0Qe WRPV3bQDX/Pg5YR8DEYuOIPk+h4FupOYCOJead3cjx17hBs054iBAQtLRN6W40ymWUAY rI0uzeViiuUuiKEw2L2AeneqdTHzlhH10RIzdxvMC+TUrx0jTUhWdJNZmzXjPjnQepLk MR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678549335; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/xmfn18hkN0OkaR4hcCpyZSJ1ppveeCqgILhTv/NVSw=; b=CZA+AjY7pBz6iPAZYhOO1+V5ud1HWDlCE/QZFk/Q3WP9R9lfRaE4BBSjp/xucJUQnI OvGHefSmf/ahF8ALBZudqiFOOzfyfz/UrZdawRK/ffK3SFnEoGv1v45NAPH3KifmjPgZ Ob5HFR2WNWMb5kRi8vRoM4zJWMVeU48aIhsvAiM8OordU7pgN8+qrZ8Mfeh7X67FY6qI e+Qk5TkDk2uDvNLwm6rpDIVzmjkSgFzHk+oPdBredFwabDzRDbiQPqR2tc4QYMKVRT2y uDzrDVTqBYhDoEts3i4dRJ2ghZoiMD88gowyTe643SaZROdgMbkiALkcLzmfwr9H4hsi oPAA== X-Gm-Message-State: AO0yUKWEOwcFIDJZ5dMS5oPJABkdTN9Yx88iEC4cROwiWDlAOvEkUyP6 0jbla/LC8wn0nSyr7HawgcE= X-Google-Smtp-Source: AK7set9YjAfx+qK2Guk7gkvhYhkixyL9dtDfajtkGtUpY9PwcSVXdwWbA9FyfqX0rHP6LYeCf7GcqA== X-Received: by 2002:a62:1dd6:0:b0:622:e1ad:2534 with SMTP id d205-20020a621dd6000000b00622e1ad2534mr650725pfd.6.1678549334910; Sat, 11 Mar 2023 07:42:14 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id e2-20020a63e002000000b00502f1540c4asm1688999pgh.81.2023.03.11.07.42.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 07:42:14 -0800 (PST) Message-ID: <444a2cf7-c3a9-255e-63eb-12ccd8f06df0@gmail.com> Date: Sat, 11 Mar 2023 08:42:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Testsuite: Disable micromips for MSA tests Content-Language: en-US To: Xin Liu , gcc-patches@gcc.gnu.org Cc: Matthew Fortune References: <20230221023857.211542-1-xin.liu@oss.cipunited.com> From: Jeff Law In-Reply-To: <20230221023857.211542-1-xin.liu@oss.cipunited.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/23 19:39, Xin Liu wrote: > From: Matthew Fortune > > --- > gcc/testsuite/gcc.target/mips/mips.exp | 1 + > 1 file changed, 1 insertion(+) Unfortunately, you haven't given anyone any background that would allow them to evaluate/review this patch. I'm guessing that MSA does not support micromips, is that correct? And for the future, please include a ChangeLog entry with patches. A ChangeLog entry describes what changed, not why something changes. A reasonable ChangeLog for this patch might be: gcc/testsuite: * gcc.target/mips/mips.exp (mips-dg-options): Disable micromips for MSA tests. Jeff