From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 0F81B3858D33 for ; Wed, 22 Feb 2023 13:03:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F81B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id u14so4740164ple.7 for ; Wed, 22 Feb 2023 05:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0vmIo8o0DWPlxSL299vHehyYU0QxmmPZ0TCZ2MsrAYA=; b=nr4mFKwZjG/MP8VbqQb2MYLQ1RVzIkoSMpNFwozLrFCWlWEWovPNn+YDhlzuRJXnqo V0NQ9kxWtsQS6enliysnaWv6Qi3tKVUvWCDtB256BReKRNb771WsTwuoUxOacx4X4Xz1 gyAaInMdX19qPh3D7M5Rpsr1w7gpIBnFnhPyY2qTuKbdpLxFRVoKV11qxMmNZ+cxmLf0 kFbYrFr0/5QqbZnGv4d5TgTuXVUbgYZVZAbTC356p2jKVoiFwIIcdQETog203cKumibk d++ZJHfjExB28E+SfYIIxrCeakzLA7fV/QN52a4HW7PIRQrCsrbGaWjpeOSkg+rWw6iE XctQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0vmIo8o0DWPlxSL299vHehyYU0QxmmPZ0TCZ2MsrAYA=; b=TCFmSlfdXl6g3469lzIZs7CqwBzXO9pYVebTaD+tpx4vvLmeKSTlPW1SxcxXgnWiPD lOxlmuETUfa5surtFyQl4QVWdRmn6NPVLsTYnjrj62cjRoDBjWnAJPWEFh/7Siq34AVx ftxya+3/GxnN6D12Rmpajhox68l/X1gWPj3rRX5Bf1YEurpzznseataiDSlpi++kDjf7 2vf0qa/FwvgKcwi4OV5GfOaC88Ks+v1NBi/1cuVgdLfR0YOJ5yfP4YpMnleQwkzF7q6S gG0E2WqYDfnsfVqmlYM8gA7OqrkCmWNuwg3e/7oIm9omkJ/1KJIs8gQdtZ8m1hWzA0uP X1Pw== X-Gm-Message-State: AO0yUKVASrLmxWwrJf0SqCGvrLle0XcsmFjy+46dZMPp82wsj9iOu3D4 kvcLAi3tfZRK2Ib6nmj6N0A= X-Google-Smtp-Source: AK7set8KKQpJqgCjk9SzSncruKLbgj57AshfYij5d7ggtlRtde3MRVoSd/lTLbQLG7ML2bLWzF1L7A== X-Received: by 2002:a17:90b:1d90:b0:234:24c9:f347 with SMTP id pf16-20020a17090b1d9000b0023424c9f347mr10422861pjb.15.1677070981103; Wed, 22 Feb 2023 05:03:01 -0800 (PST) Received: from ?IPV6:2001:f40:91b::31ee? ([2001:f40:91b::31ee]) by smtp.gmail.com with ESMTPSA id cx24-20020a17090afd9800b00233acae2ce6sm3509141pjb.23.2023.02.22.05.02.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 05:03:00 -0800 (PST) Message-ID: <444d6992-0a0e-f07f-b584-add6dbe72780@gmail.com> Date: Wed, 22 Feb 2023 13:02:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] cygwin: Don't try to support multilibs [PR107998] Content-Language: en-US To: Jakub Jelinek , Stromeko@NexGo.DE Cc: gcc-patches@gcc.gnu.org References: From: Jonathan Yong <10walls@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/22/23 09:25, Jakub Jelinek wrote: > Hi! > > As discussed in the PR, t-cygwin-w64 file has been introduced in 2013 > and has one important problem, two different multilib options -m64 and -m32, > but MULTILIB_DIRNAMES with just one word in it. > Before the genmultilib sanity checking was added, my understanding is that > this essentially resulted in effective --disable-multilib, > $ gcc -print-multi-lib > .; > ;@m32 > $ gcc -print-multi-directory > . > $ gcc -print-multi-directory -m64 > . > $ gcc -print-multi-directory -m32 > > $ gcc -print-multi-os-directory > ../lib > $ gcc -print-multi-os-directory -m64 > ../lib > $ gcc -print-multi-os-directory -m32 > ../lib32 > and because of the way e.g. config-ml.in operates > multidirs= > for i in `${CC-gcc} --print-multi-lib 2>/dev/null`; do > dir=`echo $i | sed -e 's/;.*$//'` > if [ "${dir}" = "." ]; then > true > else > if [ -z "${multidirs}" ]; then > multidirs="${dir}" > else > multidirs="${multidirs} ${dir}" > fi > fi > done > dir was . first time (and so nothing was done) and empty > second time, multidirs empty too, so multidirs was set to empty > like it would be with --disable-multilib. > > With the added sanity checking the build fails unless --disable-multilib > is used in configure (dunno whether people usually configure that way > on cygwin). > >>>From what has been said in the PR, multilibs were not meant to be supported > and e.g. cygwin headers probably aren't ready for it. > > So the following patch just removes the file with the (incorrect) multilib > stuff instead of fixing it (say by setting MULTILIB_DIRNAMES to 64 32). > > I have no way to test this though, no Windows around, can anyone please > test this? I just would like to get some progress on the P1s we have... > > 2023-02-22 Jakub Jelinek > > PR target/107998 > * config.gcc (x86_64-*-cygwin*): Don't add i386/t-cygwin-w64 into > $tmake_file. > * config/i386/t-cygwin-w64: Remove. > > --- gcc/config.gcc.jj 2023-02-18 12:38:30.803025062 +0100 > +++ gcc/config.gcc 2023-02-21 17:07:12.143164563 +0100 > @@ -2105,7 +2105,7 @@ x86_64-*-cygwin*) > need_64bit_isa=yes > tm_file="${tm_file} i386/unix.h i386/bsd.h i386/gas.h i386/cygming.h i386/cygwin.h i386/cygwin-w64.h i386/cygwin-stdint.h" > xm_file=i386/xm-cygwin.h > - tmake_file="${tmake_file} i386/t-cygming t-slibgcc i386/t-cygwin-w64" > + tmake_file="${tmake_file} i386/t-cygming t-slibgcc" > target_gtfiles="$target_gtfiles \$(srcdir)/config/i386/winnt.cc" > extra_options="${extra_options} i386/cygming.opt i386/cygwin.opt" > extra_objs="${extra_objs} winnt.o winnt-stubs.o" > --- gcc/config/i386/t-cygwin-w64.jj 2020-01-12 11:54:36.333414616 +0100 > +++ gcc/config/i386/t-cygwin-w64 2023-02-21 17:06:44.121572616 +0100 > @@ -1,3 +0,0 @@ > -MULTILIB_OPTIONS = m64/m32 > -MULTILIB_DIRNAMES = 64 > -MULTILIB_OSDIRNAMES = ../lib ../lib32 > > Jakub > Achim, mind looking at this? Resending due to mail client problems, hopefully not a duplicate.