From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jeff Law <jeffreyalaw@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Patch ping Re: [PATCH] i386: Fix up ix86_gimplify_va_arg [PR105331]
Date: Thu, 28 Apr 2022 12:31:48 +0200 (CEST) [thread overview]
Message-ID: <4451q2s-551p-5p97-6n5p-353r49op73p3@fhfr.qr> (raw)
In-Reply-To: <Ympsv1iGWdGqYXIW@tucnak>
On Thu, 28 Apr 2022, Jakub Jelinek wrote:
> On Thu, Apr 28, 2022 at 10:39:39AM +0200, Uros Bizjak wrote:
> > > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> > > >
> > > > 2022-04-22 Jakub Jelinek <jakub@redhat.com>
> > > >
> > > > PR target/105331
> > > > * config/i386/i386.cc (ix86_gimplify_va_arg): Mark va_arg_tmp
> > > > temporary TREE_ADDRESSABLE before trying to gimplify ADDR_EXPR
> > > > of it.
> > > >
> > > > * gcc.dg/pr105331.c: New test.
> >
> > Sorry, I have no idea if this patch is correct or not.
>
> Richard or Jeff, could you please review it instead?
OK.
Thanks,
Richard.
next prev parent reply other threads:[~2022-04-28 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:25 Jakub Jelinek
2022-04-28 8:31 ` Patch ping " Jakub Jelinek
2022-04-28 8:39 ` Uros Bizjak
2022-04-28 10:30 ` Jakub Jelinek
2022-04-28 10:31 ` Richard Biener [this message]
2022-04-28 13:16 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4451q2s-551p-5p97-6n5p-353r49op73p3@fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).