public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Chung-Ju Wu <jasonwucj@gmail.com>
To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>,
	"Jason.Wu@anshingtek.com.tw" <Jason.Wu@anshingtek.com.tw>
Subject: Re: [PATCH 2/3][ARM] STAR-MC1 CPU Support - arm: Add individual star-mc1 cost tables and cost functions
Date: Wed, 8 Jun 2022 16:32:17 +0800	[thread overview]
Message-ID: <448057c3-2c6d-c462-49ab-4f22bfde1ebb@gmail.com> (raw)
In-Reply-To: <PAXPR08MB69260D05058B5CA38FD7B46F93A29@PAXPR08MB6926.eurprd08.prod.outlook.com>

Hi Kyrylo,

On 2022/06/06 22:18 UTC+8, Kyrylo Tkachov wrote:
> I'd rather not duplicate those structures and functions in the master branch, as they provide a maintenance burden to the community.
> If some tuning parameters need to be modified in the future for better performance we can create star-mc1-specific structures on demand then.
> Thus, I think we don't want this patch.
> Thanks,
> Kyrill

Thanks for the comment.

Indeed, considering the maintenance burden to community, having those duplicate
structures in the master branch is not a good idea.

I am planning to contribute the star-mc1 pipeline machine description in the future.
Maybe it would be better to propose new star-mc1 specific structure along with pipeline
implementation then.

Thanks for the review.  I won't apply this 2/3 patch.

Regards,
jasonwucj

      reply	other threads:[~2022-06-08  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  7:18 Chung-Ju Wu
2022-06-06 14:18 ` Kyrylo Tkachov
2022-06-08  8:32   ` Chung-Ju Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448057c3-2c6d-c462-49ab-4f22bfde1ebb@gmail.com \
    --to=jasonwucj@gmail.com \
    --cc=Jason.Wu@anshingtek.com.tw \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).