From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 734433857BA3 for ; Wed, 8 Jun 2022 08:31:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 734433857BA3 Received: by mail-pl1-x62a.google.com with SMTP id o17so17042338pla.6 for ; Wed, 08 Jun 2022 01:31:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eO/+N9kdz04hwbUHA3rK/JAC/b4HdTxmTN67s6c6k5U=; b=4WWHBLak38nmMROm/i9RjVvZ0Z2rxNlQLLEBY6yPGfXi+GNLSzFcur51wFkqSM2Rz4 NhTUnSa08WS0B7MfsiOaVXxYMiHCPcx8cxCR0eAiZ8wxLCisNUnC5jvCk3GwMUxa4hwG 9LC/BhglsPFCesbwL/ia0hkGSOy/sqN4vmPFQ6Vtaj9zTKQ1UanyurAiSi0nX6ufpqxF 05m/YfYuh1NBsW6Z87LJ9jIwXHOwlvfbz9Hm+3gZO98Xmfz9XBirYmfEJOchdZCRtCbx NuJ+mLqBbPxGzS0GWek19qcNdEX30IGV+oRAnhPfkvSQGTtorgbDlm1kBrYDHGzLR3BC B8xA== X-Gm-Message-State: AOAM530ioYCdDkmbA1cZIeDjuUYKjW82aX6Vt3+XWou3bnLshmi2hGWZ +117HZDHdZSKRC9C6SjOKi0= X-Google-Smtp-Source: ABdhPJyCfE93B1lgcxENrcuPoIE6t60MMjVg2E+8QDFI166Vd9qHtZudNkmDGDWMN/Mxwi1RaoWLHw== X-Received: by 2002:a17:902:f314:b0:165:ddfc:5d84 with SMTP id c20-20020a170902f31400b00165ddfc5d84mr33415359ple.171.1654677106125; Wed, 08 Jun 2022 01:31:46 -0700 (PDT) Received: from [10.223.1.10] (114-43-74-68.dynamic-ip.hinet.net. [114.43.74.68]) by smtp.gmail.com with ESMTPSA id 185-20020a6303c2000000b003fc5fd21752sm14844897pgd.50.2022.06.08.01.31.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 01:31:45 -0700 (PDT) Message-ID: <448057c3-2c6d-c462-49ab-4f22bfde1ebb@gmail.com> Date: Wed, 8 Jun 2022 16:32:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/3][ARM] STAR-MC1 CPU Support - arm: Add individual star-mc1 cost tables and cost functions Content-Language: en-US To: Kyrylo Tkachov , gcc-patches Cc: Richard Earnshaw , "Jason.Wu@anshingtek.com.tw" References: From: Chung-Ju Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 08:31:49 -0000 Hi Kyrylo, On 2022/06/06 22:18 UTC+8, Kyrylo Tkachov wrote: > I'd rather not duplicate those structures and functions in the master branch, as they provide a maintenance burden to the community. > If some tuning parameters need to be modified in the future for better performance we can create star-mc1-specific structures on demand then. > Thus, I think we don't want this patch. > Thanks, > Kyrill Thanks for the comment. Indeed, considering the maintenance burden to community, having those duplicate structures in the master branch is not a good idea. I am planning to contribute the star-mc1 pipeline machine description in the future. Maybe it would be better to propose new star-mc1 specific structure along with pipeline implementation then. Thanks for the review. I won't apply this 2/3 patch. Regards, jasonwucj