From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119505 invoked by alias); 8 Feb 2019 02:49:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118945 invoked by uid 89); 8 Feb 2019 02:49:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.2 spammy=ch, HContent-Transfer-Encoding:8bit X-HELO: mail-qk1-f193.google.com Received: from mail-qk1-f193.google.com (HELO mail-qk1-f193.google.com) (209.85.222.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Feb 2019 02:49:01 +0000 Received: by mail-qk1-f193.google.com with SMTP id w204so1313118qka.2 for ; Thu, 07 Feb 2019 18:48:54 -0800 (PST) Return-Path: Received: from [192.168.1.115] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id 36sm797670qtz.15.2019.02.07.18.48.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 18:48:51 -0800 (PST) Subject: Re: [PATCH] print correct array sizes in errors (PR 87996) To: Martin Sebor , "gcc-patches@gcc.gnu.org" References: <0b3c92dc-6d35-d4cb-b2df-536432523bab@gmail.com> <0d772e1d-648d-ce03-38fc-7d8dd6ad1201@redhat.com> <90b7194e-a92e-d07b-b146-fad3733090f1@gmail.com> <4e79caa5-2438-3812-894d-9faeda3e81bb@redhat.com> <2f335cc3-d69f-b685-45fd-b358014be16c@gmail.com> <78213a67-4aea-857b-c958-fc4626e0ab0e@gmail.com> <23a79236-cd30-f995-3cce-384c976a545a@redhat.com> <8f8b65ab-1383-1dea-b5b7-fff29af53b15@gmail.com> <744e3682-1869-b260-f0a9-e365b3d57f35@gmail.com> From: Jason Merrill Message-ID: <4498a77e-b0f1-265f-c877-7e7804f27276@redhat.com> Date: Fri, 08 Feb 2019 02:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <744e3682-1869-b260-f0a9-e365b3d57f35@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00418.txt.bz2 On 2/7/19 6:27 PM, Martin Sebor wrote: > On 2/7/19 4:00 PM, Jason Merrill wrote: >> On 2/7/19 1:57 PM, Martin Sebor wrote: >>> +  /* The original numeric size as seen in the source code after >>> +     any substitution and before conversion to size_t.  */ >> >> I don't think this should mention substitution.  With that tweak the >> C++ changes are OK. > > Does someone still need to approve the rest?  Those changes are > trivial: they just move max_object_size from builtins.{c,h} to > tree.{c.h}. > > The change to c-parser.c was accidental and wasn't meant to be > included it in the last diff.  I attach yet another update with > that bit removed (and the tweak comment above). OK. Jason