Re: [Patch, fortran]

[Paul Thomas <paulthomas2@wanadoo.fr>]

Steve Kargl wrote:

> + if (type == BT_LOGICAL && cp->low->expr_type == EXPR_CONSTANT)
> + {
> + if (cp->low->value.logical & seen_logical)
>
> Do you want & or && here?

The arithmetic and was intentional. However, I realised in replying to 
you that the first operand is incorrect; the patch only fixes repeated 
.TRUE.!

This is what I will submit:
if (type == BT_LOGICAL && cp->low->expr_type == EXPR_CONSTANT)
{
int value;
value = cp->low->value.logical == 0 ? 2 : 1;
if (value & seen_logical)
{
gfc_error ("constant logical value in CASE statement "
"is repeated at %L",
&cp->low->where);
t = FAILURE;
break;
}
seen_logical |= value;
}

>
> Otherwise, the patch is OK.

Many thanks for this and the review of the FORALL patch.

Paul