From: Tobias Burnus <tobias@codesourcery.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: [Patch] omp-grid.c – add cast to silence different enumeration types warning
Date: Fri, 3 Apr 2020 11:02:13 +0200 [thread overview]
Message-ID: <449b24ed-5395-1050-4c31-4a17807688cc@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]
Hi,
that's based on https://users.suse.com/~mliska/clang-warnings.txt
which has for omp-grid.c:
/home/marxin/BIG/buildbot/buildworker/marxinbox-gcc-clang/build/gcc/omp-grid.c:1070:7: warning: comparison of two values with different enumeration types in switch statement ('enum tree_code' and 'omp_clause_code') [-Wenum-compare-switch]
/home/marxin/BIG/buildbot/buildworker/marxinbox-gcc-clang/build/gcc/omp-grid.c:1081:7: warning: comparison of two values with different enumeration types in switch statement ('enum tree_code' and 'omp_clause_code') [-Wenum-compare-switch]
/home/marxin/BIG/buildbot/buildworker/marxinbox-gcc-clang/build/gcc/omp-grid.c:1082:7: warning: comparison of two values with different enumeration types in switch statement ('enum tree_code' and 'omp_clause_code') [-Wenum-compare-switch]
/home/marxin/BIG/buildbot/buildworker/marxinbox-gcc-clang/build/gcc/omp-grid.c:1083:7: warning: comparison of two values with different enumeration types in switch statement ('enum tree_code' and 'omp_clause_code') [-Wenum-compare-switch]
Those are all for the same switch statement;
gomp_for contains 'tree clauses' and this clauses's '->code' is used
to handle store 'enum omp_clauses_code' values in in gimple.{h,c}.
I think adding this cast (and only this one) makes sense and it
also silences a (clang) compiler warning.
OK?
Tobias
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
[-- Attachment #2: omp-warn.diff --]
[-- Type: text/x-patch, Size: 1082 bytes --]
omp-grid.c – add cast to silence different enumeration types warning
* omp-grid.c (grid_eliminate_combined_simd_part): Add cast
to omp_clause_code to silence compiler warning.
diff --git a/gcc/omp-grid.c b/gcc/omp-grid.c
index b98e45de6a0..878977da2f9 100644
--- a/gcc/omp-grid.c
+++ b/gcc/omp-grid.c
@@ -1058,21 +1058,21 @@ grid_eliminate_combined_simd_part (gomp_for *parloop)
while (*tgt)
tgt = &OMP_CLAUSE_CHAIN (*tgt);
/* Copy over all clauses, except for linear clauses, which are turned into
private clauses, and all other simd-specific clauses, which are
ignored. */
tree *pc = gimple_omp_for_clauses_ptr (simd);
while (*pc)
{
tree c = *pc;
- switch (TREE_CODE (c))
+ switch ((omp_clause_code) TREE_CODE (c))
{
case OMP_CLAUSE_LINEAR:
{
tree priv = build_omp_clause (UNKNOWN_LOCATION, OMP_CLAUSE_PRIVATE);
OMP_CLAUSE_DECL (priv) = OMP_CLAUSE_DECL (c);
OMP_CLAUSE_CHAIN (priv) = NULL;
*tgt = priv;
tgt = &OMP_CLAUSE_CHAIN (priv);
pc = &OMP_CLAUSE_CHAIN (c);
break;
next reply other threads:[~2020-04-03 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:02 Tobias Burnus [this message]
2020-04-03 9:08 ` Jakub Jelinek
2020-04-03 10:43 ` [Patch] HSA: omp-grid.c – access proper clause code (was: Re: [Patch] omp-grid.c – add cast to silence different enumeration types warning) Tobias Burnus
2020-04-06 12:32 ` Jakub Jelinek
2020-04-09 17:46 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449b24ed-5395-1050-4c31-4a17807688cc@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).