From: Jason Merrill <jason@redhat.com>
To: Patrick Palka <ppalka@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: concept-ids and value-dependence [PR102412]
Date: Tue, 21 Sep 2021 20:24:53 -0400 [thread overview]
Message-ID: <44b38a29-f2fe-2a34-8b93-ac4f48704ea5@redhat.com> (raw)
In-Reply-To: <20210921133000.3128600-1-ppalka@redhat.com>
On 9/21/21 09:30, Patrick Palka wrote:
> case TEMPLATE_ID_EXPR:
> - return concept_definition_p (TREE_OPERAND (expression, 0));
> + return concept_definition_p (TREE_OPERAND (expression, 0))
> + && any_dependent_template_arguments_p (TREE_OPERAND (expression, 1));
Hmm, do we even need to check concept_definition_p? Even if other
template-ids don't get here, if they did they would also be dependent if
they had dependent template arguments.
OK either way.
Jason
next prev parent reply other threads:[~2021-09-22 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 13:30 Patrick Palka
2021-09-22 0:24 ` Jason Merrill [this message]
2021-09-22 14:37 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44b38a29-f2fe-2a34-8b93-ac4f48704ea5@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).