From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 0A4AB3857C51 for ; Fri, 18 Nov 2022 20:11:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A4AB3857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x632.google.com with SMTP id 4so5542643pli.0 for ; Fri, 18 Nov 2022 12:11:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+M3kNrbj33NpYmYGQi3JbHSAdAxgwJyNssusfBvo+bM=; b=mHQXLLzdbxzKQMGTA2UzzfS13wMwbpo1ZhmWzXqzJOlAV+Xr+6g0iX0yCKffVQRhp4 mBekGZ6WYS2nFkZU+saabQbIf6s0B1fTDngNxxD5SJqGV0pvS+UUYlYtqd+KYlsNrNuL 4wlmD0uLZLJnmiPpyJEMDjlPLkzfoQw05exqHxrX5TUpHn+CksgYZLZX9DMRZfjm5bB2 ZJlA7n/LqQ0yDQpkyqbB2570bZnRcpZlUTTto+PcxOX4iBj9uoiMh/EAAtv+EXXzwBF4 taSW4kek5iIDqja9Ym3Du/7Q5vgO0OOHMqTFQ7ebgxFyezV8IO3LRyzxrL8OLMeyW6+z I+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+M3kNrbj33NpYmYGQi3JbHSAdAxgwJyNssusfBvo+bM=; b=UO2REacnKfNWgObLyXGtVRjlTxRXim4ga+fgJVkXZNHGI/TPPeI1WbevbyNQUTgZXV T0xkrm5/GUsoyjIpd5rHwVIfglV+U2r0tx+WATY6eAdEQlMmtyJtvb40n+UgErWTsZJb SnzsKtIH58lH2GuFhSWI4urn6dDpQ94sOw3DO/9Lpd/YlXkBwq5XMs2PvD79oIV/xPOf NMaBsOxNtxl33yTnrE1xNvNVxNTKB25HEH8iz+fbCg6ijj/UCb77LSTMWYewhrGhCyVA SS6AY945Q3hprqKH40dWAIHaUoYj2kg+TIRPWwT/80J4p7/pLh1yGvdoH2ygsQRB730L tW9w== X-Gm-Message-State: ANoB5pktgFLSl5t8Nvl/tExj3ueHIoFiWXG8YzBTmQLSirUeglYyXU2g HCm7YEkIQYHpZihkDWA9g8k= X-Google-Smtp-Source: AA0mqf6XgE9PQnBTUDg7Qv+boUFJjUA1MGKBSDi0RRco5oUqrUM8tv0bNaQTC57I8WEFREF6a6WO9Q== X-Received: by 2002:a17:902:f7c1:b0:188:6baf:1ffe with SMTP id h1-20020a170902f7c100b001886baf1ffemr1057751plw.113.1668802285887; Fri, 18 Nov 2022 12:11:25 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id m15-20020a17090a4d8f00b0020af2411721sm3112836pjh.34.2022.11.18.12.11.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 12:11:25 -0800 (PST) Message-ID: <44c463f0-5ef7-abc7-bc9b-e2c195394086@gmail.com> Date: Fri, 18 Nov 2022 13:11:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2] RISC-V: No extensions for SImode min/max against safe constant Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Kito Cheng , Jeff Law , Christoph Muellner , Palmer Dabbelt , Vineet Gupta References: <20221109000631.2814859-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20221109000631.2814859-1-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/22 17:06, Philipp Tomsich wrote: > Optimize the common case of a SImode min/max against a constant > that is safe both for sign- and zero-extension. > E.g., consider the case > int f(unsigned int* a) > { > const int C = 1000; > return *a * 3 > C ? C : *a * 3; > } > where the constant C will yield the same result in DImode whether > sign- or zero-extended. > > This should eventually go away once the lowering to RTL smartens up > and considers the precision/signedness and the value-ranges of the > operands to MIN_EXPR nad MAX_EXPR. > > gcc/ChangeLog: > > * config/riscv/bitmanip.md (*minmax): Additional pattern for > min/max against constants that are extension-invariant. > * config/riscv/iterators.md (minmax_optab): Add an iterator > that has only min and max rtl. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/zbb-min-max-02.c: New test. Ok jeff