From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id D1256383D804 for ; Wed, 11 May 2022 08:17:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1256383D804 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B4BAB1F8C7; Wed, 11 May 2022 08:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1652257078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S92LwdDUFv4NgQy+iz02GtNOnDMLfrQBVlNqDCDBp8M=; b=Ni8Z2BqieGv/PCY43QEXGax7QzxZJ4I3d09rG0z1ecyhIskFWNwDlDR5bPGpWRwj85vnqU eckw1L/dLWtrwLcZrJfa1M8Df9SUDfE+k9137aLrqxyHctN+9vVW1jpb8yqwVWiLdByOq9 xxSLZspBjiPF8UcDPLdJugh+vWZH0L8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1652257078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S92LwdDUFv4NgQy+iz02GtNOnDMLfrQBVlNqDCDBp8M=; b=jEGcLJvxLj4nmz9hDa56+S64qYdeGZdyCNnOgqYaRgxnH2Ngw3pEBQ00BeZG7oV6iFB/Vz 21D7QH2gGv1u8+DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8EACA139F9; Wed, 11 May 2022 08:17:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SOh+ITZxe2LIaQAAMHmgww (envelope-from ); Wed, 11 May 2022 08:17:58 +0000 Message-ID: <44ed5715-8af0-88a9-8f82-d868df9e33d7@suse.cz> Date: Wed, 11 May 2022 10:17:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] Use more ARRAY_SIZE. Content-Language: en-US To: Richard Biener Cc: Iain Buclaw , GCC Patches , David Malcolm , Tobias Burnus , Jason Merrill References: <1651754853.85hnr42bjs.astroid@pulse.none> <934763f4-4d77-dd93-5d6e-1107380c5b06@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 08:18:01 -0000 On 5/9/22 14:03, Richard Biener wrote: > On Thu, May 5, 2022 at 4:30 PM Martin Liška wrote: >> >> On 5/5/22 14:58, Iain Buclaw wrote: >>> This D front-end change doesn't look right to me, besides the slight >> >> Hello. >> >> Sorry, I've re-read the patch and fixed some places where the macro usage >> was wrong. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > The middle-end parts are OK. I'd say in files where ARRAY_SIZE is already > used it's OK to introduce more uses. Otherwise I defer to the more specific > maintainers if they like this or not. All right, CCing the following maintainers for other parts: - David for JIT and Analyzer - Tobias for Fortran part - Jason for C-family part Thanks, Martin > > Richard. > >> Martin