From: Eric Botcazou <ebotcazou@adacore.com>
To: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [ARM] Fix ICE during thunk generation with -mlong-calls
Date: Mon, 24 Sep 2018 09:26:00 -0000 [thread overview]
Message-ID: <4513247.hs9z0gJsOX@polaris> (raw)
In-Reply-To: <c9da4f67-ebbd-2d0d-190e-4e6b634b3d68@arm.com>
> Ah! But that still doesn't explain why you want to skip these passes
> when building thunks.
They simply don't work because there is no CFG for thunks; I can add a blurb
about that.
> So is the barrier correct, or isn't it? There's really no two ways
> about this. I don't like arbitrary changes that are justified solely on
> 'that's what another port does'.
The barrier is required by the arm_reorg pass, but it is optional when the
pass is not run. I think that we can consider that it is also correct.
--
Eric Botcazou
next prev parent reply other threads:[~2018-09-24 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 11:23 Eric Botcazou
2018-09-17 13:14 ` Richard Earnshaw (lists)
2018-09-18 9:18 ` Eric Botcazou
2018-09-18 10:51 ` Richard Earnshaw (lists)
2018-09-24 9:26 ` Eric Botcazou [this message]
2018-09-25 14:31 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4513247.hs9z0gJsOX@polaris \
--to=ebotcazou@adacore.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).