public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mikael Morin <morin-mikael@orange.fr>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
	gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Cc: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: Missing error with IMPLICIT none (external) [PR100972]
Date: Fri, 5 Nov 2021 21:00:15 +0100	[thread overview]
Message-ID: <451a789c-218e-ff08-fca1-32277a76583c@orange.fr> (raw)
In-Reply-To: <20211031172520.3841446-1-rep.dot.nop@gmail.com>

Le 31/10/2021 à 18:25, Bernhard Reutner-Fischer via Fortran a écrit :
> As Gerhard Steinmetz noticed, gfc_match_implicit_none() had a notify_std
> that mentioned IMPORT instead of IMPLICIT. Fix that typo.
> 
> IMPLICIT NONE (external) is supposed to require external procedures to
> be explicitly declared with EXTERNAL.
> We cannot do this when parsing in e.g.
> gfc_match_rvalue->gfc_match_varspec because the procedure might live
> way down in a CONTAINS like in bind-c-contiguous-3.f90.
> Hence diagnose missing EXTERNAL declaraions when resolving.
> 
> Bootstrapped and regtested on x86_64-unknown-linux without regressions.
> Ok for trunk?

OK, thanks.

Mikael

      reply	other threads:[~2021-11-05 20:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-31 17:25 Bernhard Reutner-Fischer
2021-11-05 20:00 ` Mikael Morin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451a789c-218e-ff08-fca1-32277a76583c@orange.fr \
    --to=morin-mikael@orange.fr \
    --cc=aldot@gcc.gnu.org \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rep.dot.nop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).