From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 068EF3858D33; Tue, 28 Feb 2023 16:18:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 068EF3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,222,1673942400"; d="diff'?scan'208";a="98330928" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 28 Feb 2023 08:18:32 -0800 IronPort-SDR: iGOY6kPwKibzJbxFIKo1Uu774grHa2GeEKY0gZRTDtA75DDf0d3bT9XFi/QMoiJcomYdO3gsvk MaIe1rwG2IBigE/GIzh9EX6sPW2ZrMFjFjEUemHy57MXeB7+YX0XwBuKumru6MiU4Cmt5FugoA /TPkO/fYAqofKOSXcPX3bMmGNmUt/aztD0aXO92CuDvIwSjBVup8BHan54iCm/Q/xITmH+AFhA MnUJlmxrmnvISHYz/oBSINyfbYGJe24sSCPMSS3JhtkgWuZPypPhixM+TlPVRzucOg6dr3tEw0 pA4= Content-Type: multipart/mixed; boundary="------------e9S0cdtLqnfE2G3QXm8ZOKu6" Message-ID: <452ab67b-34f5-d816-436d-33f8f9ac44d4@codesourcery.com> Date: Tue, 28 Feb 2023 17:18:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US From: Tobias Burnus To: gcc-patches , Jakub Jelinek CC: fortran Subject: [Patch] OpenMP/Fortran: Fix handling of optional is_device_ptr + bind(C) [PR108546] X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------e9S0cdtLqnfE2G3QXm8ZOKu6 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable (That's a[11/12/13 Regression] P2 regression) The problem is that an is-pre= sent check on the receiver side (inside the target region) does not make much sense; the !=3D NULL check needs to be done before the GOMP_target_ext but it *is* already there. (Having the check inside the target region failed with an ICE.) Additionally, I encountered an issue for 'void *' alias 'type(c_ptr)'. That's on the Fortran-language side represented as derived type with private component(s), but then mapped to 'void*'. In any case, it lead to 'map(to: p) map(pset: p)' and the former will be at some point get TYPE_UNIT_SIZE(TREE_TYPE(*p)) but '*p' is void, giving an ICE in omp-lower ... OK for mainline =E2=80=93 and later backport to 12 + 1= 1? Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------e9S0cdtLqnfE2G3QXm8ZOKu6 Content-Type: text/x-patch; charset="UTF-8"; name="pr108546-v3.diff" Content-Disposition: attachment; filename="pr108546-v3.diff" Content-Transfer-Encoding: base64 T3Blbk1QL0ZvcnRyYW46IEZpeCBoYW5kbGluZyBvZiBvcHRpb25hbCBpc19kZXZpY2VfcHRy ICsgYmluZChDKSBbUFIxMDg1NDZdCgpGb3IgaXNfZGV2aWNlX3B0ciwgb3B0aW9uYWwgY2hl Y2tzIHNob3VsZCBvbmx5IGJlIGRvbmUgYmVmb3JlIGNhbGxpbmcKbGliZ29tcCwgYWZ0ZXJ3 YXJkcyB0aGV5IGFyZSBOVUxMIGVpdGhlciBiZWNhdXNlIG9mIGFic2VudCBvciwgYnkKY2hh bmNlLCBiZWNhdXNlIGl0IGlzIHVuYWxsb2NhdGVkIG9yIHVuYXNzb2NpYXRlZCAoZm9yIHBv aW50ZXJzL2FsbG9jYXRhYmxlcykuCgpBZGRpdGlvbmFsbHksIGl0IGZpeGVzIGFuIGlzc3Vl IHdpdGggZXhwbGljaXQgbWFwcGluZyBmb3IgJ3R5cGUoY19wdHIpJy4KCglQUiBtaWRkbGUt ZW5kLzEwODU0NgoKZ2NjL2ZvcnRyYW4vQ2hhbmdlTG9nOgoKCSogdHJhbnMtb3Blbm1wLmNj IChnZmNfdHJhbnNfb21wX2NsYXVzZXMpOiBGaXggbWFwcGluZyBvZgoJdHlwZShDX3B0cikg dmFyaWFibGVzLgoKZ2NjL0NoYW5nZUxvZzoKCgkqIG9tcC1sb3cuY2MgKGxvd2VyX29tcF90 YXJnZXQpOiBSZW1vdmUgb3B0aW9uYWwgaGFuZGxpbmcKCW9uIHRoZSByZWNlaXZlciBzaWRl LCBpLmUuIGluc2lkZSB0YXJnZXQgKGRhdGEpLCBmb3IKCXVzZV9kZXZpY2VfcHRyLgoKbGli Z29tcC9DaGFuZ2VMb2c6CgoJKiB0ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2lzX2Rldmlj ZV9wdHItMy5mOTA6IE5ldyB0ZXN0LgoJKiB0ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL3Vz ZV9kZXZpY2VfcHRyLW9wdGlvbmFsLTQuZjkwOiBOZXcgdGVzdC4KCiBnY2MvZm9ydHJhbi90 cmFucy1vcGVubXAuY2MgICAgICAgICAgICAgICAgICAgICAgICB8ICA0ICstCiBnY2Mvb21w LWxvdy5jYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAzICstCiAu Li4vdGVzdHN1aXRlL2xpYmdvbXAuZm9ydHJhbi9pc19kZXZpY2VfcHRyLTMuZjkwICB8IDQ2 ICsrKysrKysrKysrKysrKysrKysKIC4uLi9saWJnb21wLmZvcnRyYW4vdXNlX2RldmljZV9w dHItb3B0aW9uYWwtNC5mOTAgIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKwogNCBmaWxl cyBjaGFuZ2VkLCAxMDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9nY2MvZm9ydHJhbi90cmFucy1vcGVubXAuY2MgYi9nY2MvZm9ydHJhbi90cmFucy1v cGVubXAuY2MKaW5kZXggMmQxNmYzYmU4ZWEuLjg0YzAxODRmNDhlIDEwMDY0NAotLS0gYS9n Y2MvZm9ydHJhbi90cmFucy1vcGVubXAuY2MKKysrIGIvZ2NjL2ZvcnRyYW4vdHJhbnMtb3Bl bm1wLmNjCkBAIC0zMTUyLDcgKzMxNTIsOSBAQCBnZmNfdHJhbnNfb21wX2NsYXVzZXMgKHN0 bXRibG9ja190ICpibG9jaywgZ2ZjX29tcF9jbGF1c2VzICpjbGF1c2VzLAogCQkJICAgICAg IHx8IEdGQ19ERUNMX0NSQVlfUE9JTlRFRSAoZGVjbCkKIAkJCSAgICAgICB8fCBHRkNfREVT Q1JJUFRPUl9UWVBFX1AKIAkJCQkJICAgICAoVFJFRV9UWVBFIChUUkVFX1RZUEUgKGRlY2wp KSkKLQkJCSAgICAgICB8fCBuLT5zeW0tPnRzLnR5cGUgPT0gQlRfREVSSVZFRCkpCisJCQkg ICAgICAgfHwgKG4tPnN5bS0+dHMudHlwZSA9PSBCVF9ERVJJVkVECisJCQkJICAgJiYgKG4t PnN5bS0+dHMudS5kZXJpdmVkLT50cy5mOTBfdHlwZQorCQkJCSAgICAgICAhPSBCVF9WT0lE KSkpKQogCQkgICAgewogCQkgICAgICB0cmVlIG9yaWdfZGVjbCA9IGRlY2w7CiAKZGlmZiAt LWdpdCBhL2djYy9vbXAtbG93LmNjIGIvZ2NjL29tcC1sb3cuY2MKaW5kZXggZmVmNDFhMDEz ZWMuLjk3NTc1OTJjNjM1IDEwMDY0NAotLS0gYS9nY2Mvb21wLWxvdy5jYworKysgYi9nY2Mv b21wLWxvdy5jYwpAQCAtMTM5NDIsNyArMTM5NDIsOCBAQCBsb3dlcl9vbXBfdGFyZ2V0IChn aW1wbGVfc3RtdF9pdGVyYXRvciAqZ3NpX3AsIG9tcF9jb250ZXh0ICpjdHgpCiAJICAgICAg fQogCSAgICB0cmVlIHByZXNlbnQ7CiAJICAgIHByZXNlbnQgPSAoKGRvX29wdGlvbmFsX2No ZWNrCi0JCQkmJiBPTVBfQ0xBVVNFX0NPREUgKGMpICE9IE9NUF9DTEFVU0VfSEFTX0RFVklD RV9BRERSKQorCQkJJiYgT01QX0NMQVVTRV9DT0RFIChjKSAhPSBPTVBfQ0xBVVNFX0hBU19E RVZJQ0VfQUREUgorCQkJJiYgT01QX0NMQVVTRV9DT0RFIChjKSAhPSBPTVBfQ0xBVVNFX0lT X0RFVklDRV9QVFIpCiAJCSAgICAgICA/IG9tcF9jaGVja19vcHRpb25hbF9hcmd1bWVudCAo T01QX0NMQVVTRV9ERUNMIChjKSwgdHJ1ZSkKIAkJICAgICAgIDogTlVMTF9UUkVFKTsKIAkg ICAgaWYgKHByZXNlbnQpCmRpZmYgLS1naXQgYS9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21w LmZvcnRyYW4vaXNfZGV2aWNlX3B0ci0zLmY5MCBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdv bXAuZm9ydHJhbi9pc19kZXZpY2VfcHRyLTMuZjkwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwLi5hYjlmMDBlYmVjYgotLS0gL2Rldi9udWxsCisrKyBiL2xpYmdv bXAvdGVzdHN1aXRlL2xpYmdvbXAuZm9ydHJhbi9pc19kZXZpY2VfcHRyLTMuZjkwCkBAIC0w LDAgKzEsNDYgQEAKK21vZHVsZSBtCisgICB1c2UgaXNvX2NfYmluZGluZworICAgaW1wbGlj aXQgbm9uZQorY29udGFpbnMKKyAgIHN1YnJvdXRpbmUgcyh4LHkseikKKyAgICAgIHR5cGUo Y19wdHIpLCBvcHRpb25hbCA6OiB4CisgICAgICBpbnRlZ2VyLCBwb2ludGVyLCBvcHRpb25h bCA6OiB5CisgICAgICBpbnRlZ2VyLCBhbGxvY2F0YWJsZSwgb3B0aW9uYWwgOjogegorICAg ICAgbG9naWNhbCBpc19wcmVzZW50LCBpc19udWxsCisgICAgICBpc19wcmVzZW50ID0gcHJl c2VudCh4KQorICAgICAgaWYgKGlzX3ByZXNlbnQpICYKKyAgICAgICAgaXNfbnVsbCA9IC5u b3QuIGNfYXNzb2NpYXRlZCh4KQorCisgICAgICAhJG9tcCB0YXJnZXQgaXNfZGV2aWNlX3B0 cih4KSBoYXNfZGV2aWNlX2FkZHIoeSkgaGFzX2RldmljZV9hZGRyKHopCisgICAgICAgIGlm IChpc19wcmVzZW50KSB0aGVuCisgICAgICAgICAgaWYgKGlzX251bGwpIHRoZW4KKyAgICAg ICAgICAgIGlmIChjX2Fzc29jaWF0ZWQoeCkpIHN0b3AgMQorICAgICAgICAgICAgaWYgKGFz c29jaWF0ZWQoeSkpIHN0b3AgMgorICAgICAgICAgICAgaWYgKGFsbG9jYXRlZCh6KSkgc3Rv cCAzCisgICAgICAgICAgZWxzZQorICAgICAgICAgICAgaWYgKC5ub3QuIGNfYXNzb2NpYXRl ZCh4LCBjX2xvYyh5KSkpIHN0b3AgNAorICAgICAgICAgICAgaWYgKHkgLz0gNykgc3RvcCA1 CisgICAgICAgICAgICBpZiAoeiAvPSA5KSBzdG9wIDYKKyAgICAgICAgICBlbmQgaWYKKyAg ICAgICAgZW5kIGlmCisgICAgICAhJG9tcCBlbmQgdGFyZ2V0CisgICBlbmQKK2VuZAorCit1 c2UgbQoraW1wbGljaXQgbm9uZQoraW50ZWdlciwgcG9pbnRlciA6OiBwCitpbnRlZ2VyLCBh bGxvY2F0YWJsZSA6OiBhCitwID0+IG51bGwoKQorY2FsbCBzKCkKKyEkb21wIHRhcmdldCBk YXRhIG1hcChwLGEpIHVzZV9kZXZpY2VfYWRkcihwLGEpCisgIGNhbGwgcyhjX251bGxfcHRy LCBwLCBhKQorISRvbXAgZW5kIHRhcmdldCBkYXRhCithbGxvY2F0ZShwLGEpCitwID0gNwor YSA9IDkKKyEkb21wIHRhcmdldCBkYXRhIG1hcChwLGEpIHVzZV9kZXZpY2VfYWRkcihwLGEp CisgIGNhbGwgcyhjX2xvYyhwKSwgcCwgYSkKKyEkb21wIGVuZCB0YXJnZXQgZGF0YQorZGVh bGxvY2F0ZShwLGEpCitlbmQKZGlmZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdv bXAuZm9ydHJhbi91c2VfZGV2aWNlX3B0ci1vcHRpb25hbC00LmY5MCBiL2xpYmdvbXAvdGVz dHN1aXRlL2xpYmdvbXAuZm9ydHJhbi91c2VfZGV2aWNlX3B0ci1vcHRpb25hbC00LmY5MApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uYjJhNWMzMTQ2ODUKLS0t IC9kZXYvbnVsbAorKysgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmZvcnRyYW4vdXNl X2RldmljZV9wdHItb3B0aW9uYWwtNC5mOTAKQEAgLTAsMCArMSw1MyBAQAorISBQUiBtaWRk bGUtZW5kLzEwODU0NgorIQorbW9kdWxlIG0KKyAgIHVzZSBpc29fY19iaW5kaW5nCisgICBp bXBsaWNpdCBub25lCisgICB0eXBlKGNfcHRyKSA6OiBwMiwgcDMKK2NvbnRhaW5zCisgICBz dWJyb3V0aW5lIHMoeCx5LHopCisgICAgICB0eXBlKGNfcHRyKSwgb3B0aW9uYWwgOjogeAor ICAgICAgaW50ZWdlciwgcG9pbnRlciwgb3B0aW9uYWwgOjogeQorICAgICAgaW50ZWdlciwg YWxsb2NhdGFibGUsIG9wdGlvbmFsLCB0YXJnZXQgOjogegorICAgICAgbG9naWNhbCBpc19w cmVzZW50LCBpc19udWxsCisgICAgICBpc19wcmVzZW50ID0gcHJlc2VudCh4KQorICAgICAg aWYgKGlzX3ByZXNlbnQpICYKKyAgICAgICAgaXNfbnVsbCA9IC5ub3QuIGNfYXNzb2NpYXRl ZCh4KQorCisgICAgICAhJG9tcCB0YXJnZXQgZGF0YSB1c2VfZGV2aWNlX3B0cih4KSB1c2Vf ZGV2aWNlX2FkZHIoeSkgdXNlX2RldmljZV9hZGRyKHopCisgICAgICAgIGlmIChpc19wcmVz ZW50KSB0aGVuCisgICAgICAgICAgaWYgKGlzX251bGwpIHRoZW4KKyAgICAgICAgICAgIGlm IChjX2Fzc29jaWF0ZWQoeCkpIHN0b3AgMQorICAgICAgICAgICAgaWYgKGFzc29jaWF0ZWQo eSkpIHN0b3AgMgorICAgICAgICAgICAgaWYgKGFsbG9jYXRlZCh6KSkgc3RvcCAzCisgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgaWYgKC5ub3QuIGNfYXNzb2NpYXRlZCh4LCBwMikp IHN0b3AgNAorICAgICAgICAgICAgaWYgKC5ub3QuIGNfYXNzb2NpYXRlZChjX2xvYyh5KSwg cDIpKSBzdG9wIDUKKyAgICAgICAgICAgIGlmICgubm90LiBjX2Fzc29jaWF0ZWQoY19sb2Mo eiksIHAzKSkgc3RvcCA2CisgICAgICAgICAgZW5kIGlmCisgICAgICAgIGVuZCBpZgorICAg ICAgISRvbXAgZW5kIHRhcmdldCBkYXRhCisgICBlbmQKK2VuZAorCit1c2UgbQoraW1wbGlj aXQgbm9uZQordHlwZShjX3B0cikgOjogY3AKK2ludGVnZXIsIHBvaW50ZXIgOjogcAoraW50 ZWdlciwgYWxsb2NhdGFibGUsIHRhcmdldCA6OiBhCitjYWxsIHMoKQorcCA9PiBudWxsKCkK K2NhbGwgcyhjX251bGxfcHRyLCBwLCBhKQorYWxsb2NhdGUocCxhKQorcCA9IDcKK2EgPSA5 CitjcCA9IGNfbG9jKHApCishJG9tcCB0YXJnZXQgZW50ZXIgZGF0YSBtYXAodG86IGNwLCBw LCBhKQorISRvbXAgdGFyZ2V0IG1hcChmcm9tOiBwMiwgcDMpCisgIHAyID0gY19sb2MocCkK KyAgcDMgPSBjX2xvYyhhKQorISRvbXAgZW5kIHRhcmdldAorY2FsbCBzKGNwLCBwLCBhKQor ISRvbXAgdGFyZ2V0IGV4aXQgZGF0YSBtYXAoZGVsZXRlOiBjcCwgcCwgYSkKK2RlYWxsb2Nh dGUocCxhKQorZW5kCg== --------------e9S0cdtLqnfE2G3QXm8ZOKu6--