From: Matthias Kretz <m.kretz@gsi.de>
To: <gcc-patches@gcc.gnu.org>, <libstdc++@gcc.gnu.org>
Subject: [PATCH 6/7] libstdc++: Fix incorrect __builtin_is_constant_evaluated calls
Date: Wed, 15 Feb 2023 21:50:07 +0100 [thread overview]
Message-ID: <45331655.fMDQidcC6G@minbar> (raw)
In-Reply-To: <3238840.44csPzL39Z@minbar>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
libstdc++-v3/ChangeLog:
* include/experimental/bits/simd_x86.h
(_SimdImplX86::_S_not_equal_to, _SimdImplX86::_S_less)
(_SimdImplX86::_S_less_equal): Do not call
__builtin_is_constant_evaluated in constexpr-if.
---
.../include/experimental/bits/simd_x86.h | 21 +++++++++++--------
1 file changed, 12 insertions(+), 9 deletions(-)
--
──────────────────────────────────────────────────────────────────────────
Dr. Matthias Kretz https://mattkretz.github.io
GSI Helmholtz Centre for Heavy Ion Research https://gsi.de
stdₓ::simd
──────────────────────────────────────────────────────────────────────────
[-- Attachment #2: 0006-libstdc-Fix-incorrect-__builtin_is_constant_evaluate.patch --]
[-- Type: text/x-patch, Size: 2392 bytes --]
diff --git a/libstdc++-v3/include/experimental/bits/simd_x86.h b/libstdc++-v3/include/experimental/bits/simd_x86.h
index 60e80d394ba..dcfdc2a9496 100644
--- a/libstdc++-v3/include/experimental/bits/simd_x86.h
+++ b/libstdc++-v3/include/experimental/bits/simd_x86.h
@@ -2344,15 +2344,16 @@ template <typename _Abi, typename>
else
__assert_unreachable<_Tp>();
} // }}}
- else if constexpr (!__builtin_is_constant_evaluated() // {{{
- && sizeof(__x) == 8)
+ else if (__builtin_is_constant_evaluated())
+ return _Base::_S_not_equal_to(__x, __y);
+ else if constexpr (sizeof(__x) == 8)
{
const auto __r128 = __vector_bitcast<_Tp, 16 / sizeof(_Tp)>(__x)
!= __vector_bitcast<_Tp, 16 / sizeof(_Tp)>(__y);
_MaskMember<_Tp> __r64;
__builtin_memcpy(&__r64._M_data, &__r128, sizeof(__r64));
return __r64;
- } // }}}
+ }
else
return _Base::_S_not_equal_to(__x, __y);
}
@@ -2451,15 +2452,16 @@ template <typename _Abi, typename>
else
__assert_unreachable<_Tp>();
} // }}}
- else if constexpr (!__builtin_is_constant_evaluated() // {{{
- && sizeof(__x) == 8)
+ else if (__builtin_is_constant_evaluated())
+ return _Base::_S_less(__x, __y);
+ else if constexpr (sizeof(__x) == 8)
{
const auto __r128 = __vector_bitcast<_Tp, 16 / sizeof(_Tp)>(__x)
< __vector_bitcast<_Tp, 16 / sizeof(_Tp)>(__y);
_MaskMember<_Tp> __r64;
__builtin_memcpy(&__r64._M_data, &__r128, sizeof(__r64));
return __r64;
- } // }}}
+ }
else
return _Base::_S_less(__x, __y);
}
@@ -2558,15 +2560,16 @@ template <typename _Abi, typename>
else
__assert_unreachable<_Tp>();
} // }}}
- else if constexpr (!__builtin_is_constant_evaluated() // {{{
- && sizeof(__x) == 8)
+ else if (__builtin_is_constant_evaluated())
+ return _Base::_S_less_equal(__x, __y);
+ else if constexpr (sizeof(__x) == 8)
{
const auto __r128 = __vector_bitcast<_Tp, 16 / sizeof(_Tp)>(__x)
<= __vector_bitcast<_Tp, 16 / sizeof(_Tp)>(__y);
_MaskMember<_Tp> __r64;
__builtin_memcpy(&__r64._M_data, &__r128, sizeof(__r64));
return __r64;
- } // }}}
+ }
else
return _Base::_S_less_equal(__x, __y);
}
next prev parent reply other threads:[~2023-02-15 20:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 20:48 [PATCH 0/7] Work on PR108030 and several simd bugfixes and testsuite improvements Matthias Kretz
2023-02-15 20:49 ` [PATCH 1/7] libstdc++: Ensure __builtin_constant_p isn't lost on the way Matthias Kretz
2023-02-15 23:20 ` Jonathan Wakely
2023-02-15 20:49 ` [PATCH 2/7] libstdc++: Annotate most lambdas with always_inline Matthias Kretz
2023-02-16 14:10 ` Jonathan Wakely
2023-02-15 20:49 ` [PATCH 3/7] libstdc++: Document timeout and timeout-factor of simd tests Matthias Kretz
2023-02-15 23:17 ` Jonathan Wakely
2023-02-15 20:49 ` [PATCH 4/7] libstdc++: Use a PCH to speed up check-simd Matthias Kretz
2023-02-16 14:13 ` Jonathan Wakely
2023-02-15 20:50 ` [PATCH 5/7] libstdc++: printf format string fix in testsuite Matthias Kretz
2023-02-15 23:16 ` Jonathan Wakely
2023-02-15 20:50 ` Matthias Kretz [this message]
2023-02-15 23:21 ` [PATCH 6/7] libstdc++: Fix incorrect __builtin_is_constant_evaluated calls Jonathan Wakely
2023-02-15 20:50 ` [PATCH 7/7] libstdc++: Fix incorrect function call in -ffast-math optimization Matthias Kretz
2023-02-15 23:19 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45331655.fMDQidcC6G@minbar \
--to=m.kretz@gsi.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).