From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3794 invoked by alias); 23 Jul 2014 22:05:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3779 invoked by uid 89); 23 Jul 2014 22:05:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: qmta10.westchester.pa.mail.comcast.net Received: from qmta10.westchester.pa.mail.comcast.net (HELO qmta10.westchester.pa.mail.comcast.net) (76.96.62.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Jul 2014 22:05:09 +0000 Received: from omta04.westchester.pa.mail.comcast.net ([76.96.62.35]) by qmta10.westchester.pa.mail.comcast.net with comcast id Vul21o0040ldTLk5Ay570s; Wed, 23 Jul 2014 22:05:07 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by omta04.westchester.pa.mail.comcast.net with comcast id Vy561o00J2ztT3H01y57zp; Wed, 23 Jul 2014 22:05:07 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PING, PATCH, testsuite] Reliably prune GCC notes in C++ compat suite From: Mike Stump In-Reply-To: <201407231142.s6NBgXCD019089@d06av02.portsmouth.uk.ibm.com> Date: Wed, 23 Jul 2014 22:17:00 -0000 Cc: gcc-patches@gcc.gnu.org Content-Transfer-Encoding: 7bit Message-Id: <453904D4-D812-4633-9E45-9420912A7FD6@comcast.net> References: <201407231142.s6NBgXCD019089@d06av02.portsmouth.uk.ibm.com> To: Ulrich Weigand X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg01591.txt.bz2 On Jul 23, 2014, at 4:42 AM, Ulrich Weigand wrote: > Ping? Ok. >> Hello, >> >> in testing the rs6000 ABI patches I noted a weird effect: usually, the >> -Wpsabi warning notes are ignored in the compat test suites, so we get >> a clean test run anyway. >> >> However, when running the C++ version of the struct-layout-1.exp case >> *alone* (using RUNTESTFLAGS=struct-layout-1.exp), suddenly tests are >> failing because of those extra notes. This does *not* happen with >> the C version of that suite ... >> >> It turns out that that pruning those notes is supposed to happen >> from within gcc-defs.exp:${tool}_check_compile: >> if { [info proc ${tool}-dg-prune] != "" } { >> global target_triplet >> set gcc_output [${tool}-dg-prune $target_triplet $gcc_output] >> } >> >> However, the g++-dg-prune routine is defined in g++-dg.exp, which >> is never included from g++.dg/compat/struct-layout-1.exp (directly >> or indirectly). Now, when running the full suite, that file would >> have been loaded by some earlier g++.dg .exp file, so everything >> works out. But when running struct-layout-1.exp stand-alone, the >> g++-dg-prune routine is never defined and thus silently no pruning >> takes place. >> >> To fix this, the following patch simply loads g++-dg.exp directly >> from g++.dg/compat/struct-layout-1.exp. >> >> Tested on powerpc64-linux and powerpc64le-linux. >> >> OK for mainline (and 4.8/4.9 once the rs6000 ABI patches are >> backported there)? >> >> Bye, >> Ulrich >> >> >> gcc/testsuite/ChangeLog: >> >> * g++.dg/compat/struct-layout-1.exp: Load g++-dg.exp >> >> >> Index: gcc-4_9-branch/gcc/testsuite/g++.dg/compat/struct-layout-1.exp >> =================================================================== >> --- gcc-4_9-branch.orig/gcc/testsuite/g++.dg/compat/struct-layout-1.exp >> +++ gcc-4_9-branch/gcc/testsuite/g++.dg/compat/struct-layout-1.exp >> @@ -89,6 +89,9 @@ proc compat-use-tst-compiler { } { >> # This must be done after the compat-use-*-compiler definitions. >> load_lib compat.exp >> >> +# Provide the g++-dg-prune routine (gcc-dp.exp is loaded by compat.exp) >> +load_lib g++-dg.exp >> + >> g++_init >> >> # Save variables for the C++ compiler under test, which each test will >> >> -- >> Dr. Ulrich Weigand >> GNU/Linux compilers and toolchain >> Ulrich.Weigand@de.ibm.com >> > > > -- > Dr. Ulrich Weigand > GNU/Linux compilers and toolchain > Ulrich.Weigand@de.ibm.com >