public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Dennis Zhang <Dennis.Zhang@arm.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>,
	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [Ping][PATCH][Arm] ACLE 8-bit integer matrix multiply-accumulate intrinsics
Date: Fri, 21 Feb 2020 11:47:00 -0000	[thread overview]
Message-ID: <4541122e-229a-9147-4b02-9cf1c49fb948@foss.arm.com> (raw)
In-Reply-To: <3b319753-5b00-8cf6-5a8a-804117902774@arm.com>

Hi Dennis,

On 2/11/20 12:03 PM, Dennis Zhang wrote:
> Hi all,
>
> On 16/12/2019 13:45, Dennis Zhang wrote:
> > Hi all,
> >
> > This patch is part of a series adding support for Armv8.6-A features.
> > It depends on the Arm Armv8.6-A CLI patch,
> > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02195.html.
> > It also depends on the Armv8.6-A effective target checking patch,
> > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00857.html.
> > It also depends on the ARMv8.6-A I8MM dot product patch for using the
> > same builtin qualifier
> > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00945.html.
> >
> > This patch adds intrinsics for matrix multiply-accumulate operations
> > including vmmlaq_s32, vmmlaq_u32, and vusmmlaq_s32.
> >
> > ACLE documents are at https://developer.arm.com/docs/101028/latest
> > ISA documents are at https://developer.arm.com/docs/ddi0596/latest
> >
> > Regtested for arm-none-linux-gnueabi-armv8.2-a.
> >
> > Is it OK for trunk please?
> >

This is ok.

Thanks,

Kyrill



> > Thanks,
> > Dennis
> >
> > gcc/ChangeLog:
> >
> > 2019-12-10  Dennis Zhang  <dennis.zhang@arm.com>
> >
> >      * config/arm/arm_neon.h (vmmlaq_s32, vmmlaq_u32, vusmmlaq_s32): 
> New.
> >      * config/arm/arm_neon_builtins.def (smmla, ummla, usmmla): New.
> >      * config/arm/iterators.md (MATMUL): New.
> >      (sup): Add UNSPEC_MATMUL_S, UNSPEC_MATMUL_U, and UNSPEC_MATMUL_US.
> >      (mmla_sfx): New.
> >      * config/arm/neon.md (neon_<sup>mmlav16qi): New.
> >      * config/arm/unspecs.md (UNSPEC_MATMUL_S): New.
> >      (UNSPEC_MATMUL_U, UNSPEC_MATMUL_US): New.
> >
> > gcc/testsuite/ChangeLog:
> >
> > 2019-12-10  Dennis Zhang  <dennis.zhang@arm.com>
> >
> >      * gcc.target/arm/simd/vmmla_1.c: New test.
>
> This patch has been updated according to the feedback on related AArch64
> version at https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01591.html
>
> Regtested. OK to commit please?
>
> Many thanks
> Dennis
>
> gcc/ChangeLog:
>
> 2020-02-11  Dennis Zhang  <dennis.zhang@arm.com>
>
>         * config/arm/arm-builtins.c (USTERNOP_QUALIFIERS): New macro.
>         * config/arm/arm_neon.h (vmmlaq_s32, vmmlaq_u32, 
> vusmmlaq_s32): New.
>         * config/arm/arm_neon_builtins.def (smmla, ummla, usmmla): New.
>         * config/arm/iterators.md (MATMUL): New iterator.
>         (sup): Add UNSPEC_MATMUL_S, UNSPEC_MATMUL_U, and UNSPEC_MATMUL_US.
>         (mmla_sfx): New attribute.
>         * config/arm/neon.md (neon_<sup>mmlav16qi): New.
>         * config/arm/unspecs.md (UNSPEC_MATMUL_S, UNSPEC_MATMUL_U): New.
>         (UNSPEC_MATMUL_US): New.
>
> gcc/testsuite/ChangeLog:
>
> 2020-02-11  Dennis Zhang  <dennis.zhang@arm.com>
>
>         * gcc.target/arm/simd/vmmla_1.c: New test.

  reply	other threads:[~2020-02-21 11:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 13:51 [PATCH][Arm] " Dennis Zhang
2020-02-11 12:03 ` [Ping][PATCH][Arm] " Dennis Zhang
2020-02-21 11:47   ` Kyrill Tkachov [this message]
2020-02-21 15:43     ` Dennis Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4541122e-229a-9147-4b02-9cf1c49fb948@foss.arm.com \
    --to=kyrylo.tkachov@foss.arm.com \
    --cc=Dennis.Zhang@arm.com \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).