From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14744 invoked by alias); 21 Feb 2020 11:47:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14736 invoked by uid 89); 21 Feb 2020 11:47:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,KAM_SHORT autolearn=ham version=3.3.1 spammy=sup, zhang, Zhang, HContent-Transfer-Encoding:8bit X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2020 11:47:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0CF0331B; Fri, 21 Feb 2020 03:47:08 -0800 (PST) Received: from [10.2.80.62] (e120808-lin.cambridge.arm.com [10.2.80.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B0603F68F; Fri, 21 Feb 2020 03:47:07 -0800 (PST) Subject: Re: [Ping][PATCH][Arm] ACLE 8-bit integer matrix multiply-accumulate intrinsics To: Dennis Zhang , "gcc-patches@gcc.gnu.org" Cc: nd , Richard Earnshaw , Ramana Radhakrishnan References: <4217b60f-9032-e282-a7bf-783b26654f61@arm.com> <3b319753-5b00-8cf6-5a8a-804117902774@arm.com> From: Kyrill Tkachov Message-ID: <4541122e-229a-9147-4b02-9cf1c49fb948@foss.arm.com> Date: Fri, 21 Feb 2020 11:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <3b319753-5b00-8cf6-5a8a-804117902774@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2020-02/txt/msg01200.txt.bz2 Hi Dennis, On 2/11/20 12:03 PM, Dennis Zhang wrote: > Hi all, > > On 16/12/2019 13:45, Dennis Zhang wrote: > > Hi all, > > > > This patch is part of a series adding support for Armv8.6-A features. > > It depends on the Arm Armv8.6-A CLI patch, > > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02195.html. > > It also depends on the Armv8.6-A effective target checking patch, > > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00857.html. > > It also depends on the ARMv8.6-A I8MM dot product patch for using the > > same builtin qualifier > > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00945.html. > > > > This patch adds intrinsics for matrix multiply-accumulate operations > > including vmmlaq_s32, vmmlaq_u32, and vusmmlaq_s32. > > > > ACLE documents are at https://developer.arm.com/docs/101028/latest > > ISA documents are at https://developer.arm.com/docs/ddi0596/latest > > > > Regtested for arm-none-linux-gnueabi-armv8.2-a. > > > > Is it OK for trunk please? > > This is ok. Thanks, Kyrill > > Thanks, > > Dennis > > > > gcc/ChangeLog: > > > > 2019-12-10  Dennis Zhang  > > > >      * config/arm/arm_neon.h (vmmlaq_s32, vmmlaq_u32, vusmmlaq_s32): > New. > >      * config/arm/arm_neon_builtins.def (smmla, ummla, usmmla): New. > >      * config/arm/iterators.md (MATMUL): New. > >      (sup): Add UNSPEC_MATMUL_S, UNSPEC_MATMUL_U, and UNSPEC_MATMUL_US. > >      (mmla_sfx): New. > >      * config/arm/neon.md (neon_mmlav16qi): New. > >      * config/arm/unspecs.md (UNSPEC_MATMUL_S): New. > >      (UNSPEC_MATMUL_U, UNSPEC_MATMUL_US): New. > > > > gcc/testsuite/ChangeLog: > > > > 2019-12-10  Dennis Zhang  > > > >      * gcc.target/arm/simd/vmmla_1.c: New test. > > This patch has been updated according to the feedback on related AArch64 > version at https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01591.html > > Regtested. OK to commit please? > > Many thanks > Dennis > > gcc/ChangeLog: > > 2020-02-11  Dennis Zhang  > >         * config/arm/arm-builtins.c (USTERNOP_QUALIFIERS): New macro. >         * config/arm/arm_neon.h (vmmlaq_s32, vmmlaq_u32, > vusmmlaq_s32): New. >         * config/arm/arm_neon_builtins.def (smmla, ummla, usmmla): New. >         * config/arm/iterators.md (MATMUL): New iterator. >         (sup): Add UNSPEC_MATMUL_S, UNSPEC_MATMUL_U, and UNSPEC_MATMUL_US. >         (mmla_sfx): New attribute. >         * config/arm/neon.md (neon_mmlav16qi): New. >         * config/arm/unspecs.md (UNSPEC_MATMUL_S, UNSPEC_MATMUL_U): New. >         (UNSPEC_MATMUL_US): New. > > gcc/testsuite/ChangeLog: > > 2020-02-11  Dennis Zhang  > >         * gcc.target/arm/simd/vmmla_1.c: New test.