From: Eric Botcazou <ebotcazou@libertysurf.fr>
To: Richard Sandiford <richard.sandiford@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [SPARC] Simplify const_all_ones_operand
Date: Sat, 12 Sep 2015 09:31:00 -0000 [thread overview]
Message-ID: <4569778.oEgI0I8vMy@polaris> (raw)
In-Reply-To: <87d1yi9rn9.fsf@e105548-lin.cambridge.arm.com>
[Sorry for the delay]
> gen_rtx_CONST_VECTOR ensures that there is a single instance of:
>
> (const_vector:M [(const_int -1) ... (const_int -1)])
>
> for each M, so pointer equality with CONSTM1_RTX is enough. Also,
> HOST_BITS_PER_WIDE_INT == 32 is doubly dead: HOST_WIDE_INT is always
> 64 bits now, and we always use const_int rather than const_double
> or const_wide_int for all-ones values (or any other value that
> fits in a signed HOST_WIDE_INT).
>
> This seemed like a better fix than using the helper functions
> that I'm about to post.
>
> Tested with a cross-compiler and ensured that the predicate was
> still accepting all (-)1 values. OK to install?
>
> Thanks,
> Richard
>
> gcc/
> * config/sparc/predicates.md (const_all_ones_operand): Use
> CONSTM1_RTX to simplify definition.
OK, thanks.
--
Eric Botcazou
prev parent reply other threads:[~2015-09-12 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 10:34 Richard Sandiford
2015-09-12 9:31 ` Eric Botcazou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4569778.oEgI0I8vMy@polaris \
--to=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).