From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51582 invoked by alias); 12 Sep 2015 08:29:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51571 invoked by uid 89); 12 Sep 2015 08:29:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp6-g21.free.fr Received: from smtp6-g21.free.fr (HELO smtp6-g21.free.fr) (212.27.42.6) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 12 Sep 2015 08:29:35 +0000 Received: from polaris.localnet (unknown [88.161.99.133]) by smtp6-g21.free.fr (Postfix) with ESMTPS id 94D0982263; Sat, 12 Sep 2015 10:22:01 +0200 (CEST) From: Eric Botcazou To: Richard Sandiford Cc: gcc-patches@gcc.gnu.org Subject: Re: [SPARC] Simplify const_all_ones_operand Date: Sat, 12 Sep 2015 09:31:00 -0000 Message-ID: <4569778.oEgI0I8vMy@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <87d1yi9rn9.fsf@e105548-lin.cambridge.arm.com> References: <87d1yi9rn9.fsf@e105548-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00855.txt.bz2 [Sorry for the delay] > gen_rtx_CONST_VECTOR ensures that there is a single instance of: > > (const_vector:M [(const_int -1) ... (const_int -1)]) > > for each M, so pointer equality with CONSTM1_RTX is enough. Also, > HOST_BITS_PER_WIDE_INT == 32 is doubly dead: HOST_WIDE_INT is always > 64 bits now, and we always use const_int rather than const_double > or const_wide_int for all-ones values (or any other value that > fits in a signed HOST_WIDE_INT). > > This seemed like a better fix than using the helper functions > that I'm about to post. > > Tested with a cross-compiler and ensured that the predicate was > still accepting all (-)1 values. OK to install? > > Thanks, > Richard > > gcc/ > * config/sparc/predicates.md (const_all_ones_operand): Use > CONSTM1_RTX to simplify definition. OK, thanks. -- Eric Botcazou