From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89662 invoked by alias); 4 Dec 2015 20:48:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 89651 invoked by uid 89); 4 Dec 2015 20:48:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx5-phx2.redhat.com Received: from mx5-phx2.redhat.com (HELO mx5-phx2.redhat.com) (209.132.183.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 04 Dec 2015 20:48:24 +0000 Received: from zmail13.collab.prod.int.phx2.redhat.com (zmail13.collab.prod.int.phx2.redhat.com [10.5.83.15]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB4KmLHg017051; Fri, 4 Dec 2015 15:48:21 -0500 Date: Fri, 04 Dec 2015 20:48:00 -0000 From: Paolo Bonzini To: Jeff Law Cc: Paolo Bonzini , gcc-patches@gcc.gnu.org, joseph@codesourcery.com, jakub@redhat.com, mpolacek@redhat.com Message-ID: <457559086.34222475.1449262101433.JavaMail.zimbra@redhat.com> In-Reply-To: <5661E216.9000401@redhat.com> References: <1448459733-52373-1-git-send-email-pbonzini@redhat.com> <5661D297.2090406@gnu.org> <5661E216.9000401@redhat.com> Subject: Re: [PATCH] Do not sanitize left shifts for -fwrapv (PR68418) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00636.txt.bz2 > >> gcc: > >> PR sanitizer/68418 > >> * c-family/c-ubsan.c (ubsan_instrument_shift): Disable > >> sanitization of left shifts for wrapping signed types as well. > >> > >> gcc/testsuite: > >> PR sanitizer/68418 > >> * gcc.dg/ubsan/c99-wrapv-shift-1.c, > >> gcc.dg/ubsan/c99-wrapv-shift-2.c: New testcases. > Doesn't this change how pointer types are handled? Why would pointer types be shifted at all (at the ubsan level, which is basically the AST)? Paolo