From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 987513858427 for ; Fri, 26 Aug 2022 16:37:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 987513858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102c.google.com with SMTP id s31-20020a17090a2f2200b001faaf9d92easo8572978pjd.3 for ; Fri, 26 Aug 2022 09:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=xG8AXPBbFJpV7chls5GgEqAb/YQ/VXTG1Psla9UPn3o=; b=eK4HsQxP4nn9DYkoWQgIC/Et1zq95ls3IhtrIgvntKFuOjum74L7yFSnnGvKfvTGIK W/z3+RZJ2YcpxfCg/hb5aX5DSVJ8EABI0sxfgumv993Eo+CT3RanYdNjUa9z5gDz2Jl5 wkAMr9FcGG77KFtVJYL0SY1CZO/vz8VxZla+M2+yzyvS2IJpJ2/Tu+M0Fqef8A9/6dKE oYrGcMH1/Bh+RkAulWmu5+CnmNg4OuaVyACuCaAGxi7wqbdJrc/5cqgCOtqnOUIuO9H4 4cagrCJOVJ5vrevdnncSVGt8DfSLPa8uMrbUstClRkXBB8di8s+R9oq0hpvltRumKKKa AIQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=xG8AXPBbFJpV7chls5GgEqAb/YQ/VXTG1Psla9UPn3o=; b=ZRMKV1wx6BwVGX2rxhqymwMfaES5MsTb2ZeC+SWcJ6tBi0gr7O3B/cne7EKgQTNUg+ I0w2pMi6qFsFohbQdO531UTPYt7ttQJN9DbYlMSs16W5PVRBnIQJ0HxSjNGLZSYdYmxe FfxdZZqBlIACY6SNUQbizuiwTI+3lBw4g2Z68wryvcgAmcsTMDzJwITZhcAH422De+eR 7t8rJFyuVJfO5W/V8GkdtpqOzVkfpwJHase6xLDmnrOkVTMImxDLthFnWdm7MOUcusXZ IJB4+HFRuUZg1PC//XTLiixhHDGOhfxWazz9FFJTaALd8rWx3AMEd00Uasrjh1Q0bOTI aaiQ== X-Gm-Message-State: ACgBeo1A20C7iuAWB2yLM97Uj2dCCJbsTPq5Vd54KucKCUtkon92WU/K /IV2LxlrqZsWt7hg8kPjW29uXRl4dT0= X-Google-Smtp-Source: AA6agR6oD7Vifef37MuNCfTcQDnfMkw2XejbnG2EhLq5VvBAPGMdqzjMsD91LTwx3FiSUWkd2qm+TA== X-Received: by 2002:a17:902:f606:b0:172:6522:4bfc with SMTP id n6-20020a170902f60600b0017265224bfcmr4260379plg.133.1661531870044; Fri, 26 Aug 2022 09:37:50 -0700 (PDT) Received: from [172.31.0.204] (c-73-98-188-51.hsd1.ut.comcast.net. [73.98.188.51]) by smtp.gmail.com with ESMTPSA id p4-20020a17090a748400b001fb796c6af6sm1876291pjk.50.2022.08.26.09.37.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 09:37:49 -0700 (PDT) Message-ID: <457b0e7d-2883-0313-b9d6-9b4371d28562@gmail.com> Date: Fri, 26 Aug 2022 10:37:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] Remove uninit_analysis::use_cannot_happen Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220826065511.1057F13421@imap2.suse-dmz.suse.de> From: Jeff Law In-Reply-To: <20220826065511.1057F13421@imap2.suse-dmz.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/26/2022 12:55 AM, Richard Biener via Gcc-patches wrote: > As written earlier uninit_analysis::use_cannot_happen is duplicate > functionality implemented in a complement way, not adhering to > the idea of disproving a may-uninit use and eventually (I have not > yet found a testcase it helps to avoid false positives) avoiding > false positives because of this or different ways it imposes limits > on the predicate computations. > > This patch removes it. > > I've bootstrapped and tested this before, but re-bootstrap/test > on x86_64-unknown-linux-gnu is running now. > > * gimple-predicate-analysis.h > (uninit_analysis::use_cannot_happen): Remove. > * gimple-predicate-analysis.cc (can_be_invalidated_p): Remove. > (uninit_analysis::use_cannot_happen): Likewise. > (uninit_analysis::is_use_guarded): Do not call > use_cannot_happen. ACK.  IIRC Aldy added this several years back to deal with a uninit regression PR.  If it's not triggering anymore, I'm not going to lose any sleep over losing it. jeff