From: Jeff Law <jeffreyalaw@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>,
'GCC Patches' <gcc-patches@gcc.gnu.org>
Subject: Re: [Committed] Correct zeroextendqihi2 insn length regression on xstormy16.
Date: Tue, 25 Apr 2023 07:56:01 -0600 [thread overview]
Message-ID: <4581f076-b2d0-03af-0312-52d7af3889c3@gmail.com> (raw)
In-Reply-To: <00c101d97766$95a30a40$c0e91ec0$@nextmovesoftware.com>
On 4/25/23 05:10, Roger Sayle wrote:
>
> My recent tweak to the zeroextendqihi2 pattern on xstormy16 incorrectly
> handled the case where the operand was a MEM. MEM operands use a longer
> encoding than REG operands, and the incorrect instruction length resulted
> in assembler errors (as reported by Jeff Law). This patch restores the
> original length resolving this regression. Sorry for the inconvenience.
> Committed as obvious, after testing that a cross-compiler to xstormy16-elf
> builds from x86_64-pc-linux-gnu, and that gcc.c-torture/execute/memset-2.c
> no longer causes "operand out of range" issues in gas. Sorry again.
>
>
> 2023-04-25 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> * config/stormy16/stormy16.md (zero_extendqihi2): Restore/fix
> length attribute for the first (memory operand) alternative.
Thanks. xstormy is passing again.
jeff
prev parent reply other threads:[~2023-04-25 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 11:10 Roger Sayle
2023-04-25 13:56 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4581f076-b2d0-03af-0312-52d7af3889c3@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).