From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id E6E483857342 for ; Fri, 16 Jun 2023 04:25:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E6E483857342 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35G4MJfF017424; Fri, 16 Jun 2023 04:25:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : cc : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=5wpzcBJHkF9u4cdPr6EVO1eJD6b7M5mbWkuB5DDB1b8=; b=KrlWDsqGGkGAmKxdInTwLl4XEUb3qax9LoumEDeO5rfS/NZL+Jy9ir+yxnGHY5+UssZ8 zjBdY5AWK7U54hm3ErCoashBT+5U754JiS65RSob3M71Ozhqd2JVYCf/W0eigEyZ8y5K 9DU9gRT4Pyos6ONvdqVCzGz7XzpAvvVL01ZN1iMGESFGz4s8rtHUpOGc39wfk1Z8dXUi +FFqW+bQioHz8k2t6JBzdv11tL0pvsMhsoZXdSRPdheRKIi+Gze8xPwWj7IOn/m6ad9B V1EwmRClfj65aND+2Q3WfGbBrmAo/Sq3g7LY7sRl7fNE+fytS0iY7+qHOL8rAdrK9UE8 Bw== Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r8gn3g0yq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jun 2023 04:25:28 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35G24P15010717; Fri, 16 Jun 2023 04:25:28 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([9.208.129.120]) by ppma04wdc.us.ibm.com (PPS) with ESMTPS id 3r4gt5x59p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jun 2023 04:25:28 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35G4PRsK852670 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Jun 2023 04:25:27 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3CE8658064; Fri, 16 Jun 2023 04:25:27 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B97145805C; Fri, 16 Jun 2023 04:25:26 +0000 (GMT) Received: from [9.61.112.239] (unknown [9.61.112.239]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 16 Jun 2023 04:25:26 +0000 (GMT) Message-ID: <4586392d-ff8b-1c19-4af0-2a816fa63259@linux.ibm.com> Date: Thu, 15 Jun 2023 23:25:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] rs6000: Change bitwise xor to inequality operator [PR106907] To: P Jeevitha References: Content-Language: en-US From: Peter Bergner Cc: GCC Patches , Segher Boessenkool In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ftojjEqkwe3tua9OT0BihCDtuy_r2_DE X-Proofpoint-GUID: ftojjEqkwe3tua9OT0BihCDtuy_r2_DE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-16_01,2023-06-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306160036 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/12/23 6:18 AM, P Jeevitha wrote: > Bitwise xor performed on bool > is similar to checking inequality. So changed to inequality > operator (!=) instead of bitwise xor (^). [snip' > - if (swapped ^ !BYTES_BIG_ENDIAN [snip] > + if (swapped != !BYTES_BIG_ENDIAN I know Andreas mentioned using "swapped != !BYTES_BIG_ENDIAN" in the bugzilla, but that's the same as "swapped == BYTES_BIG_ENDIAN", and it doesn't contain a double-negative and seems a little clearer. It's up to Segher though...and if we go with this, then the ChangeLog entry needs to be updated slightly since we're no longer testing for inequality. Peter