public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <paolo.bonzini@lu.unisi.ch>
To: gcc-patches@gcc.gnu.org
Cc: Daniel Jacobowitz <drow@false.org>,
	  Mark Mitchell <mark@codesourcery.com>
Subject: Re: libgcc move to the top level
Date: Tue, 19 Dec 2006 16:09:00 -0000	[thread overview]
Message-ID: <45880EB3.7070101@lu.unisi.ch> (raw)
In-Reply-To: <20061217031435.GA31219@nevyn.them.org>

> 2006-12-16  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	* Makefile.def (target_modules): Add libgcc.
> 	(lang_env_dependencies): Remove default items.  Use no_c and no_gcc.

We actually don't need lang_env_dependencies at all.  I'll work to move 
these into target_modules (using new attributes like libstdcxx_depend, 
no_libc_depend and no_libgcc_depend respectively), but it's ok to do it 
after this is committed.

> 	* Makefile.tpl (clean-target-libgcc): Delete.
> 	(configure-target-[+module+]): Emit --disable-bootstrap dependencies
> 	on gcc even for bootstrapped modules.  Rewrite handling of
> 	lang_env_dependencies to loop over target_modules.
> 	* configure.in (target_libraries): Add target-libgcc.
> 	* Makefile.in, configure: Regenerated.
> 
> 2006-12-16  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	* Makefile.in: Update comments mentioning libgcc.
> 	(LIBGCC, INSTALL_LIBGCC, GCC_PARTS, mklibgcc): Delete.
> 	(all.cross, start.encap, rest.encap, rest.cross): Update
> 	dependencies for libgcc move.
> 	(libgcc.mk, LIBGCC_DEPS, libgcov.a, libgcc.a, stmp-multilib)
> 	(clean-target, clean-target-libgcc): Delete.
> 	(srcdirify): New macro.
> 	(libgcc-support, libgcc.mvars): New rules.
> 	(distclean): Remove mention of mklibgcc.
> 	(install): Don't reference INSTALL_LIBGCC.
> 	(install-common): Don't reference EXTRA_PARTS.
> 	(install-libgcc, install-multilib): Delete rules.
> 	* mklibgcc.in: Delete file.
> 	* doc/configfiles.texi: Don't mention mklibgcc.
> 

These bits are ok.

For the toplevel libgcc build machinery, as I told you privately I'm 
worried that moving config.gcc fragments into the libgcc config.host, 
and at the same time preserving the correct case ordering, will be a 
nightmare.  So I think that even the first version of libgcc;s 
config.host should be based on config.gcc and should already list the 
cases in the correct order.  This way, moving stuff from gcc to libgcc 
will be much easier.

I'll review the toplevel libgcc build machinery as soon as I get an 
updated patch with this change.

Also, right now, there is practically no example of how to move the 
EXTRA_PARTS to the libgcc directory.  I'd appreciate if at least one 
arch maintainer would help you moving their arch's stuff to the libgcc 
directory.  Of course it's okay if you post one such example soon after 
committing, or even better before (anyway, this would be a separate 
commit from this already huge patch).

However, I'd like to have a second opinion on everything :-) but 
especially, I'd rather have somebody else review the config/ bits (both 
in gcc and srcdir).

Thanks,

Paolo

  parent reply	other threads:[~2006-12-19 16:09 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-17  3:15 Daniel Jacobowitz
2006-12-17  3:48 ` Daniel Jacobowitz
2006-12-19 16:09 ` Paolo Bonzini [this message]
2006-12-19 19:18   ` Daniel Jacobowitz
2006-12-19 20:06     ` Paolo Bonzini
2006-12-19 20:26       ` Daniel Jacobowitz
2006-12-20  7:56         ` Paolo Bonzini
2006-12-29  2:09           ` Daniel Jacobowitz
2006-12-29 10:55             ` Paolo Bonzini
2006-12-20  0:23       ` Mike Stump
2006-12-20  0:35         ` Daniel Jacobowitz
2006-12-29 11:27     ` Paolo Bonzini
2006-12-29 14:50       ` Daniel Jacobowitz
2006-12-29 15:29         ` Paolo Bonzini
2006-12-29 16:13           ` Daniel Jacobowitz
2006-12-29 16:31             ` Paolo Bonzini
2006-12-29 16:36               ` Daniel Jacobowitz
2006-12-29 16:42                 ` Paolo Bonzini
2006-12-29 18:01             ` Daniel Jacobowitz
2006-12-30  8:20               ` Paolo Bonzini
2006-12-30 20:19                 ` Daniel Jacobowitz
2006-12-31 18:43                   ` Paolo Bonzini
2006-12-31 19:56                     ` Daniel Jacobowitz
2007-01-01 18:10                       ` Paolo Bonzini
2007-01-01 21:14                         ` Mike Stump
2007-01-08 18:17                         ` Steve Ellcey
2007-01-08 18:47                           ` Daniel Jacobowitz
2007-01-08 22:32                             ` Steve Ellcey
2007-01-08 22:51                               ` Daniel Jacobowitz
2007-01-04 12:32                       ` Andreas Schwab
2007-01-04 14:05                         ` Daniel Jacobowitz
2007-01-04 14:57                           ` Marcin Dalecki
2007-01-04 15:02                             ` Daniel Jacobowitz
2007-01-04 15:09                               ` Paolo Bonzini
2007-01-04 15:32                                 ` Marcin Dalecki
2007-01-04 15:39                                   ` Paolo Bonzini
2007-01-04 18:05                                     ` Marcin Dalecki
2007-01-04 16:13                               ` Marcin Dalecki
2007-01-04 16:34                                 ` Daniel Jacobowitz
2007-01-04 17:13                                   ` Marcin Dalecki
2007-01-04 16:52                           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45880EB3.7070101@lu.unisi.ch \
    --to=paolo.bonzini@lu.unisi.ch \
    --cc=drow@false.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).