From: Paolo Bonzini <paolo.bonzini@lu.unisi.ch>
To: Mark Shinwell <shinwell@codesourcery.com>
Cc: gcc patches <gcc-patches@gcc.gnu.org>
Subject: Re: Stricter implicit conversions between vectors, revised patch
Date: Fri, 22 Dec 2006 10:17:00 -0000 [thread overview]
Message-ID: <458BB0B6.6000200@lu.unisi.ch> (raw)
In-Reply-To: <458ABCF8.3020504@codesourcery.com>
> Paulo, there is an outstanding modification to altivec.h -- see below -- of
> which I am suspicious. For some reason __builtin_altivec_vcmpgefp is
> still being defined as returning vector signed int even though, as far as
> I can see, it should be returning vector bool int as required for the
> return type of vec_cmple.
Your AltiVec changes seem ok to me; see PR30210 (where you're already
CCed anyway) for the gory details about __builtin_vec_* versus
__builtin_altivec_* and why __builtin_altivec_vcmpgefp does not return a
vector bool int.
So, I think your patch is correct, except that you also have to change
the corresponding C++ code, which is quite wrong (predicates are defined
as templates, and this has let a wrong name through):
__altivec_binary_pred(vec_cmple,
- __builtin_altivec_cmpge (a2, a1))
+ __builtin_vec_cmpge (a2, a1))
> This patch exhibits no changes in testsuite results with all default
> languages on x86_64-unknown-linux-gnu. I haven't quite reached this
> on powerpc64-unknown-linux-gnu but I think the only outstanding problem
> is due to this vcmpgefp issue.
What is this problem?
Paolo
next prev parent reply other threads:[~2006-12-22 10:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 16:57 Mark Shinwell
2006-12-22 10:17 ` Paolo Bonzini [this message]
2006-12-22 10:35 ` Mark Shinwell
2006-12-22 13:35 ` Mark Shinwell
2006-12-23 18:46 ` Mark Shinwell
2006-12-28 8:48 ` Gerald Pfeifer
2007-01-08 9:57 ` Mark Shinwell
2007-01-08 16:00 ` Gerald Pfeifer
2007-01-03 22:17 ` Mark Mitchell
2007-01-09 4:16 ` Andrew Pinski
2007-01-11 23:17 ` Joseph S. Myers
2007-01-12 8:29 ` Paolo Bonzini
2007-01-12 13:16 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458BB0B6.6000200@lu.unisi.ch \
--to=paolo.bonzini@lu.unisi.ch \
--cc=gcc-patches@gcc.gnu.org \
--cc=shinwell@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).