From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17698 invoked by alias); 22 Dec 2006 10:17:40 -0000 Received: (qmail 17681 invoked by uid 22791); 22 Dec 2006 10:17:39 -0000 X-Spam-Check-By: sourceware.org Received: from server.usilu.net (HELO mail.usilu.net) (195.176.178.200) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Dec 2006 10:17:30 +0000 Received: from [1.240.182.245] ([213.140.22.65] RDNS failed) by mail.usilu.net over TLS secured channel with Microsoft SMTPSVC(6.0.3790.1830); Fri, 22 Dec 2006 11:17:27 +0100 Message-ID: <458BB0B6.6000200@lu.unisi.ch> Date: Fri, 22 Dec 2006 10:17:00 -0000 From: Paolo Bonzini User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: Mark Shinwell CC: gcc patches Subject: Re: Stricter implicit conversions between vectors, revised patch References: <458ABCF8.3020504@codesourcery.com> In-Reply-To: <458ABCF8.3020504@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2006-12/txt/msg01558.txt.bz2 > Paulo, there is an outstanding modification to altivec.h -- see below -- of > which I am suspicious. For some reason __builtin_altivec_vcmpgefp is > still being defined as returning vector signed int even though, as far as > I can see, it should be returning vector bool int as required for the > return type of vec_cmple. Your AltiVec changes seem ok to me; see PR30210 (where you're already CCed anyway) for the gory details about __builtin_vec_* versus __builtin_altivec_* and why __builtin_altivec_vcmpgefp does not return a vector bool int. So, I think your patch is correct, except that you also have to change the corresponding C++ code, which is quite wrong (predicates are defined as templates, and this has let a wrong name through): __altivec_binary_pred(vec_cmple, - __builtin_altivec_cmpge (a2, a1)) + __builtin_vec_cmpge (a2, a1)) > This patch exhibits no changes in testsuite results with all default > languages on x86_64-unknown-linux-gnu. I haven't quite reached this > on powerpc64-unknown-linux-gnu but I think the only outstanding problem > is due to this vcmpgefp issue. What is this problem? Paolo