From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 678833853D7D for ; Wed, 23 Nov 2022 14:58:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 678833853D7D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669215508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bbvfWaFUttuDR3L+ZZLPN4wbMdouocgwZ+pFRAWqGWk=; b=HOTfGjvsQYUoP33KoTZNxcf47DS1tl0WPExKnB0jKHAuVJXZTIsduhqBFJGz95Iy7qGiTU mX1QV/PB1ME6QfYJMhS/v54RDJdSVrc5QDcUZc/UzwqIlGHIOSYBL4ufZTAiOr9dEiagFE +tJtp5+9iIkY1ZH7hiPQhf2/AZQKNoc= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-212-wsrc7TpTNGW2HZ3BK-utIw-1; Wed, 23 Nov 2022 09:58:26 -0500 X-MC-Unique: wsrc7TpTNGW2HZ3BK-utIw-1 Received: by mail-qv1-f71.google.com with SMTP id mi12-20020a056214558c00b004bb63393567so16836950qvb.21 for ; Wed, 23 Nov 2022 06:58:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bbvfWaFUttuDR3L+ZZLPN4wbMdouocgwZ+pFRAWqGWk=; b=K4ZuIHNp/AcfDO6T/NISW3wd8ywLkiWMcrP4lin9RGTlx/2EkZLMWGt8GjqKuOThqV uzDe4pDbuSgLO0bNABuhUvQkIhg7MbKUFdHTZGYB2giuLsc75yuV4WKSSh8KvtlVi38I CvCr+yBGOd2ndYr54FKoOA/8Pvx6xcgfw1/7345M0YV/vihTiDyhQDI2DCs6IEROZKVX yndNVQ7AOdymzWGZWn06tPjww7dTBkDclB+r+btWhFpaQMsqdFu3le9gbCx1KFjxRKYw Xlp/cspij/ZRxLiaD8TZCnFG6h0e3Mcrc2g4SW0AMEVgIg/xGmqeEJ1in3xwaPjaXIP/ 3syA== X-Gm-Message-State: ANoB5pmqR7HG4B6hsh/SjALq1wvMqqUwGc4lYI5isIwxjerOzUYWI5rZ Ey2z0RzPJvrUJ71htlMSj2pyfISXJW+rss1DlFTaXrMKy3ZteJsYYvy/BFr7uEOZTSowcd4iLuC LQ8v/hn7Vd448d+MPnQ== X-Received: by 2002:a05:622a:4d94:b0:3a5:fb6c:d96a with SMTP id ff20-20020a05622a4d9400b003a5fb6cd96amr26930331qtb.185.1669215506271; Wed, 23 Nov 2022 06:58:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf5hZy1E04T4rS+5tbf7KUKUClUYs4aYpFXYKCLue/BdWtjklYL862cTMpEaxLyziglpfFPvdA== X-Received: by 2002:a05:622a:4d94:b0:3a5:fb6c:d96a with SMTP id ff20-20020a05622a4d9400b003a5fb6cd96amr26930317qtb.185.1669215506035; Wed, 23 Nov 2022 06:58:26 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id oo19-20020a05620a531300b006fa00941e9dsm11652531qkn.136.2022.11.23.06.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 06:58:25 -0800 (PST) Message-ID: <459060ccc9639f262e0dad079d8aeaaa798b4287.camel@redhat.com> Subject: Re: [PATCH] analyzer: Use __builtin_alloca in gcc.dg/analyzer/call-summaries-2.c From: David Malcolm To: Rainer Orth , gcc-patches@gcc.gnu.org Date: Wed, 23 Nov 2022 09:58:18 -0500 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2022-11-23 at 14:27 +0100, Rainer Orth wrote: > gcc.dg/analyzer/call-summaries-2.c currently FAILs on Solaris: >=20 > FAIL: gcc.dg/analyzer/call-summaries-2.c (test for excess errors) >=20 > Excess errors: > /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/call- > summaries-2.c:468:12: warning: implicit declaration of function > 'alloca' [-Wimplicit-function-declaration] > /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/call- > summaries-2.c:468:12: warning: incompatible implicit decl >=20 > alloca is only declared in , which isn't included > indirectly > anywhere.=C2=A0 To avoid this, I switched the test to use __builtin_alloc= a > instead, following the vast majority of analyzer tests that use > alloca. >=20 > Tested no i386-pc-solaris2.11, sparc-sun-solaris2.11, and > x86_64-pc-linux-gnu. >=20 > Ok for trunk? Yes Thanks Dave >=20 > There are a handful of tests that explicitly include > instead, > which is of course an alternative if preferred. >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Rainer >=20